Skip to content

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 8, 2025

Fixed #31065.

Description

The PR should fix redundant calls of setPipeline() of the WebGPU backend.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 8, 2025

@greggman I wasn't able to verify the patch with your tool since the version in the store is 0.0.34. Do you mind checking with 0.0.35 whether the redundant settings are now gone?

Copy link

github-actions bot commented May 8, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.29
78.32
336.29
78.32
+0 B
+0 B
WebGPU 548.2
152.02
548.37
152.05
+173 B
+37 B
WebGPU Nodes 547.55
151.86
547.72
151.9
+173 B
+36 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 466.23
112.58
466.23
112.58
+0 B
+0 B
WebGPU 622.98
168.71
623.15
168.75
+173 B
+38 B
WebGPU Nodes 577.85
158
578.02
158.03
+173 B
+36 B

@greggman
Copy link
Contributor

greggman commented May 8, 2025

looks fixed to me! (old on left, new on right)

Screenshot 2025-05-09 at 00 22 14

@Mugen87 Mugen87 added this to the r177 milestone May 8, 2025
@Mugen87 Mugen87 merged commit cba7408 into mrdoob:dev May 8, 2025
12 checks passed
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGPU: Stop calling setPipeline when it's the same pipeline
2 participants