Skip to content

TSL: Improve debug() callback changing to ( builder, code ) function signature #30976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 22, 2025
Merged

TSL: Improve debug() callback changing to ( builder, code ) function signature #30976

merged 5 commits into from
Apr 22, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Apr 22, 2025 •
edited
Loading

Closes #30186

Description

Change the callback signature from debug to callback( builder, code ), thus giving the developer greater options.

material.outputNode = output.debug( ( ( builder ) => {

	console.log( builder.uniforms );
	// console.log( builder.flow ); // for the current flow of code

} ) );

@sunag sunag added this to the r176 milestone Apr 22, 2025
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.33
78.33		 336.33
78.33		 +0 B
+0 B
WebGPU 547.3
151.72		 547.3
151.72		 +2 B
+1 B
WebGPU Nodes 546.65
151.56		 546.65
151.56		 +2 B
+1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.78
112.28		 465.78
112.28		 +0 B
+0 B
WebGPU 622.15
168.3		 622.15
168.3		 +2 B
+3 B
WebGPU Nodes 577.02
157.57		 577.03
157.57		 +2 B
+3 B

@sunag sunag marked this pull request as ready for review April 22, 2025 08:55
@sunag sunag merged commit 9147649 into mrdoob:dev Apr 22, 2025
12 checks passed
@sunag sunag deleted the dev-improve-debug branch April 22, 2025 08:56
This was referenced Apr 24, 2025
Merged
Closed
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@sunag @RuthySheffi
TSL: Improve debug() callback changing to ( builder, code ) funct…
2def138 
…ion signature (mrdoob#30976)

* improve debug callback

* Update DebugNode.js

* Update DebugNode.js

* Update DebugNode.js

* Update DebugNode.js
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
@sunag @RuthySheffi
TSL: Improve debug() callback changing to ( builder, code ) funct…
e41d86a 
…ion signature (mrdoob#30976)

* improve debug callback

* Update DebugNode.js

* Update DebugNode.js

* Update DebugNode.js

* Update DebugNode.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r176
Development

Successfully merging this pull request may close these issues.

Request Uniforms/Inputs from a NodeMaterial
1 participant
@sunag