webgl_reverse_depth_buffer: Use post-processing and add note for use of floating point depth #30941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of floating point depth.
| const meshes = []; | ||
|
|
||
| const renderTarget = new THREE.WebGLRenderTarget(); | ||
| renderTarget.type = THREE.UnsignedByteType; |
There was a problem hiding this comment.
Any pointers to what setting the type property does? I don't see it documented for WebGLRenderTarget and was wondering whether it needs to be added to the TypeScript types.
There was a problem hiding this comment.
I guess this should be:
renderTarget.texture.typeBut since the default is already THREE.UnsignedByteType we probably can just delete this line.
There was a problem hiding this comment.
This is a bad habit of mine. I will remove the line #30989.
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
…of floating point depth. (mrdoob#30941)
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
…of floating point depth. (mrdoob#30941)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #30809 (comment)
Description
Updates the example to configure a basic post-processing chain with a floating-point depth buffer (canvas default is integer, which doesn't work as well). The simplest form is what I had initially contributed with a single offscreen render + blit, but this is unusual for an example and will mess up tonemapping in real scenes since r155. This should now be a better showcase and realistic example.