fix(debounce): ensure debounce disposes source #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ppoliani
added a commit
to ppoliani/most
that referenced
this pull request
Aug 11, 2017
davidchase
approved these changes
Aug 11, 2017
briancavalier
pushed a commit
to cujojs/most
that referenced
this pull request
Aug 11, 2017
* Dispose the source disposable When disposing a debounce stream we also need to dispose the source disposable * add a test case for debounce dispose * drain the debounced stream in the test * fix(debounce): assign source disposable directly to debounce disposable Suggested by mostjs/core#107 * fix linting issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from cujojs/most#472
It looks like there was also a bug in the DebounceSink constructor. It wasn't correct to use disposeBoth, since the DebounceSink instance is already the disposable that is being returned from run().