Autoharness: Don't panic on _ argument and add _autoharness suffix to GOTO files
#3942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_ argument
tautschnig
approved these changes
Mar 17, 2025
_ argument_ argument and add _autoharness suffix to GOTO files
11 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
Bump Kani version to 0.61.0. Github-generated release notes: ## What's Changed * Fix CHANGELOG of 0.60.0 by @qinheping in #3925 * Bump tests/perf/s2n-quic from `d88faa4` to `8670e83` by @dependabot in #3928 * Update toolchain to 2025-03-04 by @qinheping in #3927 * Install the right toolchain for HEAD and BASE checks in `verify-std-check.yml` by @remi-delmas-3000 in #3920 * Automatic cargo update to 2025-03-10 by @github-actions in #3926 * Automatic toolchain upgrade to nightly-2025-03-05 by @github-actions in #3929 * Upgrade toolchain to nightly-2025-03-07 by @tautschnig in #3931 * Upgrade toolchain to nightly-2025-03-12 by @tautschnig in #3933 * Automatic toolchain upgrade to nightly-2025-03-13 by @github-actions in #3934 * Update CBMC dependency to 6.5.0 by @tautschnig in #3936 * Automatic toolchain upgrade to nightly-2025-03-14 by @github-actions in #3937 * Automatic toolchain upgrade to nightly-2025-03-15 by @github-actions in #3938 * Automatic toolchain upgrade to nightly-2025-03-16 by @github-actions in #3939 * Automatic toolchain upgrade to nightly-2025-03-17 by @github-actions in #3940 * Automatic cargo update to 2025-03-17 by @github-actions in #3941 * Autoharness: Don't panic on `_` argument and add `_autoharness` suffix to GOTO files by @carolynzech in #3942 * Implement `f16` and `f128` cases in `codegen_float_type` by @carolynzech in #3943 * Support function implementations of known built-ins by @tautschnig in #3945 * Autoharness: metadata improvements and enable standard library application by @carolynzech in #3948 * Autoharness: `--list` option by @carolynzech in #3952 * Add support for anonymous nested statics by @carolynzech in #3953 * Automatic cargo update to 2025-03-24 by @github-actions in #3954 * Bump tests/perf/s2n-quic from `8670e83` to `324cf31` by @dependabot in #3955 * Document behavior of checked_size_of_raw and is_inbounds by @rajath-mk in #3956 * Upgrade toolchain to 2025-03-18 by @zhassan-aws in #3959 * Remove unstable-features from code formatting script by @zhassan-aws in #3962 * Remove CI job to update features/verify-rust-std by @tautschnig in #3963 * Make is_inbounds public by @rajath-mk in #3958 * Enable Kani to work with a stable toolchain by @zhassan-aws in #3964 * Automatic cargo update to 2025-03-31 by @github-actions in #3966 * Add support for struct field accessing in loop contracts by @thanhnguyen-aws in #3970 * Bump tests/perf/s2n-quic from `324cf31` to `d0aff82` by @dependabot in #3968 * Clarify `is_inbounds` docs by @carolynzech in #3974 * Upgrade toolchain to 2025-04-01 by @carolynzech in #3973 * Remove remaining `--enable-unstable` mentions by @carolynzech in #3978 * Clean up unused dependencies by @zhassan-aws in #3981 * Automatic toolchain upgrade to nightly-2025-04-02 by @github-actions in #3983 * Update dependencies per `cargo-outdated` by @carolynzech in #3982 * Fix `autoharness` termination test & print metadata in alphabetical order by @carolynzech in #3971 * Fix cargo invocations to only use `pkg_args` where appropriate by @carolynzech in #3984 **Full Changelog**: kani-0.60.0...kani-0.61.0 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that if an argument is just
_, it doesn't havevar_debug_infoin StableMIR. So this PR changes autoharness behavior to provide_for the argument name whenvar_debug_infois None (instead of panicking).I don't currently know of any other cases where there wouldn't be
var_debug_info, but we should pay extra attention to the cases where autoharness reports_as an argument name and update this logic if need be.I also added an
_autoharnesssuffix to the generated GOTO files so that it's easier to tell which files are from autoharness and which aren't.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.