Remove kani::Arbitrary from the modifies contract instrumentation #3169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@zhassan-aws I included an extra test to cover this case. I was testing this on the function contracts we have fore stdlib. |
zhassan-aws
approved these changes
May 2, 2024
tests/expected/function-contract/modifies/simple_only_verification_modifies.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
…tion_modifies.rs Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
karkhaz
added a commit
that referenced
this pull request
May 7, 2024
For reference, here is the auto-generated changelog ## What's Changed * Upgrade toolchain to 2024-04-18 and improve toolchain workflow by @celinval in #3149 * Automatic toolchain upgrade to nightly-2024-04-19 by @github-actions in #3150 * Stabilize cover statement and update contracts RFC by @celinval in #3091 * Automatic toolchain upgrade to nightly-2024-04-20 by @github-actions in #3154 * Bump tests/perf/s2n-quic from `2d5e891` to `5f88e54` by @dependabot in #3140 * Automatic cargo update to 2024-04-22 by @github-actions in #3157 * Automatic toolchain upgrade to nightly-2024-04-21 by @github-actions in #3158 * Bump tests/perf/s2n-quic from `5f88e54` to `9730578` by @dependabot in #3159 * Fix cargo audit error by @jaisnan in #3160 * Fix cbmc-update CI job by @tautschnig in #3156 * Automatic cargo update to 2024-04-29 by @github-actions in #3165 * Bump tests/perf/s2n-quic from `9730578` to `1436af7` by @dependabot in #3166 * Do not assume that ZST-typed symbols refer to unique objects by @tautschnig in #3134 * Fix copyright check for `expected` tests by @adpaco-aws in #3170 * Remove kani::Arbitrary from the modifies contract instrumentation by @feliperodri in #3169 * Automatic cargo update to 2024-05-06 by @github-actions in #3172 * Bump tests/perf/s2n-quic from `1436af7` to `6dd41e0` by @dependabot in #3174 * Avoid unnecessary uses of Location::none() by @tautschnig in #3173 **Full Changelog**: kani-0.50.0...kani-0.51.0 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
zpzigi754
pushed a commit
to zpzigi754/kani
that referenced
this pull request
May 8, 2024
…del-checking#3169) This is an additional fix for model-checking#3098. With this fix, Kani should be able to check for contracts using modifies clauses that contain references to types that doesn't implement `kani::Arbitrary`. The verification will still fail if the same contract is used as a verified stub. --------- Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
qinheping
pushed a commit
to qinheping/kani
that referenced
this pull request
May 9, 2024
…del-checking#3169) This is an additional fix for model-checking#3098. With this fix, Kani should be able to check for contracts using modifies clauses that contain references to types that doesn't implement `kani::Arbitrary`. The verification will still fail if the same contract is used as a verified stub. --------- Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
qinheping
pushed a commit
to qinheping/kani
that referenced
this pull request
May 9, 2024
For reference, here is the auto-generated changelog ## What's Changed * Upgrade toolchain to 2024-04-18 and improve toolchain workflow by @celinval in model-checking#3149 * Automatic toolchain upgrade to nightly-2024-04-19 by @github-actions in model-checking#3150 * Stabilize cover statement and update contracts RFC by @celinval in model-checking#3091 * Automatic toolchain upgrade to nightly-2024-04-20 by @github-actions in model-checking#3154 * Bump tests/perf/s2n-quic from `2d5e891` to `5f88e54` by @dependabot in model-checking#3140 * Automatic cargo update to 2024-04-22 by @github-actions in model-checking#3157 * Automatic toolchain upgrade to nightly-2024-04-21 by @github-actions in model-checking#3158 * Bump tests/perf/s2n-quic from `5f88e54` to `9730578` by @dependabot in model-checking#3159 * Fix cargo audit error by @jaisnan in model-checking#3160 * Fix cbmc-update CI job by @tautschnig in model-checking#3156 * Automatic cargo update to 2024-04-29 by @github-actions in model-checking#3165 * Bump tests/perf/s2n-quic from `9730578` to `1436af7` by @dependabot in model-checking#3166 * Do not assume that ZST-typed symbols refer to unique objects by @tautschnig in model-checking#3134 * Fix copyright check for `expected` tests by @adpaco-aws in model-checking#3170 * Remove kani::Arbitrary from the modifies contract instrumentation by @feliperodri in model-checking#3169 * Automatic cargo update to 2024-05-06 by @github-actions in model-checking#3172 * Bump tests/perf/s2n-quic from `1436af7` to `6dd41e0` by @dependabot in model-checking#3174 * Avoid unnecessary uses of Location::none() by @tautschnig in model-checking#3173 **Full Changelog**: model-checking/kani@kani-0.50.0...kani-0.51.0 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an additional fix for #3098. With this fix, Kani should be able to check for contracts using modifies clauses that contain references to types that doesn't implement
kani::Arbitrary. The verification will still fail if the same contract is used as a verified stub.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.