[28.x backport] gha: remove GO_VERSION build-arg from builds #50348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same env-var is used for action/setup-go as for overriding the default Go version in Dockerfiles, however action/setup-go only accepts SemVer (e.g. 1.25.0-rc.1) whereas the official golang image follows the Go project's versioning, which doesn't use a SemVer-compatible format (go1.25rc1 / 1.25rc1). Trying to use the same "GO_VERSION" value for both will therefore fail. As we're already updating the default version in the Dockerfile to the version we want to use, let's remove the --build-arg, and use the default that's set in the Dockerfile. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit fa4f3c9) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport: gha: remove GO_VERSION build-arg from builds #50314
relates to [DNM] update to go1.25rc3 #50313
The same env-var is used for action/setup-go as for overriding the default Go version in Dockerfiles, however action/setup-go only accepts SemVer (e.g. 1.25.0-rc.1) whereas the official golang image follows the Go project's versioning, which doesn't use a SemVer-compatible format (go1.25rc1 / 1.25rc1).
Trying to use the same "GO_VERSION" value for both will therefore fail.
As we're already updating the default version in the Dockerfile to the version we want to use, let's remove the --build-arg, and use the default that's set in the Dockerfile.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)