[DNM] update to go1.25rc3 #50313

thaJeztah · 2025-07-02T20:29:34Z

depends on Dockerfile: bump gotest.tools/gotestsum v1.12.3 (for go1.25) #50315

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah · 2025-07-02T20:40:15Z

Interesting; what's this?

 > [gotestsum 1/1] RUN --mount=type=cache,target=/root/.cache/go-build     --mount=type=cache,target=/go/pkg/mod         GOBIN=/build/ GO111MODULE=on go install "gotest.tools/gotestsum@v1.12.0"      && /build/gotestsum --version:
4.813 go: downloading github.com/bitfield/gotestdox v0.2.2
4.814 go: downloading golang.org/x/sys v0.18.0
4.962 go: downloading golang.org/x/sync v0.6.0
5.033 go: downloading golang.org/x/term v0.18.0
5.052 go: downloading github.com/mattn/go-colorable v0.1.13
5.140 go: downloading github.com/mattn/go-isatty v0.0.20
5.213 go: downloading golang.org/x/text v0.14.0
5.768 go: downloading golang.org/x/mod v0.16.0
43.15 # golang.org/x/tools/internal/tokeninternal
43.15 pkg/mod/golang.org/x/tools@v0.19.0/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
------
Dockerfile:213
--------------------
 212 |     ARG GOTESTSUM_VERSION=v1.12.0
 213 | >>> RUN --mount=type=cache,target=/root/.cache/go-build \
 214 | >>>     --mount=type=cache,target=/go/pkg/mod \
 215 | >>>         GOBIN=/build/ GO111MODULE=on go install "gotest.tools/gotestsum@${GOTESTSUM_VERSION}" \
 216 | >>>      && /build/gotestsum --version
 217 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c GOBIN=/build/ GO111MODULE=on go install \"gotest.tools/gotestsum@${GOTESTSUM_VERSION}\"      && /build/gotestsum --version" did not complete successfully: exit code: 1
Build references
Check build summary support
Error: buildx bake failed with: ERROR: failed to solve: process "/bin/sh -c GOBIN=/build/ GO111MODULE=on go install \"gotest.tools/gotestsum@${GOTESTSUM_VERSION}\"      && /build/gotestsum --version" did not complete successfully: exit code: 1

thaJeztah · 2025-07-02T20:41:03Z

Yup; easy to reproduce;

docker run --rm golang:1.25rc1 sh -c 'go install gotest.tools/gotestsum@v1.12.0'
go: downloading gotest.tools/gotestsum v1.12.0
go: downloading github.com/dnephin/pflag v1.0.7
go: downloading github.com/fatih/color v1.16.0
go: downloading github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510
go: downloading golang.org/x/tools v0.19.0
go: downloading github.com/fsnotify/fsnotify v1.7.0
go: downloading golang.org/x/sys v0.18.0
go: downloading github.com/bitfield/gotestdox v0.2.2
go: downloading golang.org/x/sync v0.6.0
go: downloading golang.org/x/term v0.18.0
go: downloading github.com/mattn/go-colorable v0.1.13
go: downloading github.com/mattn/go-isatty v0.0.20
go: downloading golang.org/x/text v0.14.0
go: downloading golang.org/x/mod v0.16.0
# golang.org/x/tools/internal/tokeninternal
pkg/mod/golang.org/x/tools@v0.19.0/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)

thaJeztah · 2025-07-02T21:35:12Z

derp; BuildKit is using alpine 3.21;

Dockerfile:35
--------------------
  33 |     
  34 |     # golatest is alias for Go base image
  35 | >>> FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS golatest
  36 |     
  37 |     # gobuild-base is base stage for compiling go/cgo
--------------------
ERROR: failed to solve: docker.io/library/golang:1.24.0-rc.1-alpine3.21: not found

crazy-max · 2025-07-03T12:28:20Z

derp; BuildKit is using alpine 3.21;

Dockerfile:35
--------------------
  33 |     
  34 |     # golatest is alias for Go base image
  35 | >>> FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS golatest
  36 |     
  37 |     # gobuild-base is base stage for compiling go/cgo
--------------------
ERROR: failed to solve: docker.io/library/golang:1.24.0-rc.1-alpine3.21: not found

You can set ALPINE_VERSION env in:

moby/.github/workflows/buildkit.yml

Lines 145 to 153 in a8bcd0d

    
                 - 
        
                   name: Build test image 
        
                   uses: docker/bake-action@v6 
        
                   with: 
        
                     source: . 
        
                     workdir: ./buildkit 
        
                     targets: integration-tests 
        
                     set: | 
        
                       *.output=type=docker,name=${{ env.TEST_IMAGE_ID }}

      -
        name: Build test image
        uses: docker/bake-action@v6
        env:
          ALPINE_VERSION: 3.22
        with:
          source: .
          workdir: ./buildkit
          targets: integration-tests
          set: |
            *.output=type=docker,name=${{ env.TEST_IMAGE_ID }}

This will set the build-arg accordingly in the bake definition:

thaJeztah · 2025-07-03T12:57:53Z

Oh! I added it at the top, and it looks like it picks it up, but the problem may not be the alpine version, but the "SemVer" format (again)?

ERROR: failed to solve: docker.io/library/golang:1.24.0-rc.1-alpine3.22: not found

Let me check if I can fix that. Really annoying! 😂

thaJeztah · 2025-07-03T17:44:01Z

This one could be legit;

=== Failed
=== FAIL: amd64.integration-cli TestDockerDaemonSuite/TestHTTPSInfoRogueCert (0.73s)
    docker_cli_daemon_test.go:737: Expected err: bad certificate, got instead: exit status 1 and output: error during connect: Get https://localhost:4271/v1.38/info: remote error: tls: handshake failure
    --- FAIL: TestDockerDaemonSuite/TestHTTPSInfoRogueCert (0.73s)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

This was referenced Jul 2, 2025

x/tools: v0.8.0 through v0.25.0 (Oct 2024) contain public packages that fail to build with Go 1.25.0 golang/go#74462

Open

gha: remove GO_VERSION build-arg from builds #50314

Merged

Dockerfile: bump gotest.tools/gotestsum v1.12.3 (for go1.25) #50315

Merged

thaJeztah added status/2-code-review area/testing area/packaging labels Jul 2, 2025

thaJeztah force-pushed the update_go1.25 branch from c3a8672 to df926ad Compare July 2, 2025 21:14

thaJeztah force-pushed the update_go1.25 branch from df926ad to 1bea46a Compare July 3, 2025 12:22

thaJeztah force-pushed the update_go1.25 branch 2 times, most recently from daabc99 to 80fa16c Compare July 3, 2025 13:14

vvoland mentioned this pull request Jul 8, 2025

[28.x backport] gha: remove GO_VERSION build-arg from builds #50348

Merged

thaJeztah mentioned this pull request Jul 13, 2025

Dockerfile: upgrade Delve to v1.25.0 #50406

Merged

thaJeztah force-pushed the update_go1.25 branch from 80fa16c to 73f1f93 Compare July 13, 2025 15:40

thaJeztah changed the title ~~[DNM] update to go1.25rc1~~ [DNM] update to go1.25rc2 Jul 13, 2025

thaJeztah mentioned this pull request Jul 13, 2025

Dockerfile: bump gotest.tools/gotestsum v1.12.3 (for go1.25) docker/cli#6179

Merged

update to go1.25rc3

3d274b2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah force-pushed the update_go1.25 branch from 73f1f93 to 3d274b2 Compare August 8, 2025 00:28

thaJeztah changed the title ~~[DNM] update to go1.25rc2~~ [DNM] update to go1.25rc3 Aug 8, 2025

vvoland mentioned this pull request Aug 11, 2025

[28.x backport] Dockerfile: bump gotest.tools/gotestsum v1.12.3 (for go1.25) #50695

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DNM] update to go1.25rc3 #50313

[DNM] update to go1.25rc3 #50313

Uh oh!

thaJeztah commented Jul 2, 2025 •

edited

Loading

Uh oh!

thaJeztah commented Jul 2, 2025

Uh oh!

thaJeztah commented Jul 2, 2025

Uh oh!

thaJeztah commented Jul 2, 2025

Uh oh!

crazy-max commented Jul 3, 2025

Uh oh!

thaJeztah commented Jul 3, 2025

Uh oh!

thaJeztah commented Jul 3, 2025

Uh oh!

Uh oh!

[DNM] update to go1.25rc3 #50313

Are you sure you want to change the base?

[DNM] update to go1.25rc3 #50313

Uh oh!

Conversation

thaJeztah commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah commented Jul 2, 2025

Uh oh!

thaJeztah commented Jul 2, 2025

Uh oh!

thaJeztah commented Jul 2, 2025

Uh oh!

crazy-max commented Jul 3, 2025

Uh oh!

thaJeztah commented Jul 3, 2025

Uh oh!

thaJeztah commented Jul 3, 2025

Uh oh!

Uh oh!

thaJeztah commented Jul 2, 2025 •

edited

Loading