-
Notifications
You must be signed in to change notification settings - Fork 18.8k
api: Deprecate Container
and ContainerConfig
for /images/{id}/json
#46939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These fields were an implementation detail of the classic image builder and are empty when using buildkit. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
discussed in the maintainers call; we can set an empty struct for API < 1.46, and remove it in API 1.46
For future reference; there was some back-and-forth on the deprecation;
While the information can be considered somewhat useful (e.g. Re-implementing that functionality with the containerd integration involves storing it as custom metadata, which also involves significant additional complexity for a niche use-case, so;
On a side note, we also briefly discussed NOT supporting older API versions when using the containerd integration. i.e., continue the road we started with; And raise minimum supported API version with the containerd store enabled to only the last X API versions to reduce the amount of complexity for "brand new" code. |
See moby/moby#46939 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
See moby/moby#46939 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
See moby/moby#46939 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
See moby/moby#46939 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
See moby/moby#46939 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Container
property #46931These fields were an implementation detail of the classic image builder and are empty when using buildkit.
Deprecate them in API v1.44 (Moby v25) and schedule their removal for API v1.45 (Moby v26)
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)