revendor engine-api #25721
Merged
revendor engine-api #25721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6bf3c5b to
d431730
Compare
|
Found more issues with engine-api swallowing errors after a recent change, breaking some tests here: fixed in docker-archive-public/docker.engine-api#366 |
d431730 to
c58d8f6
Compare
|
@cpuguy83 merged! |
c58d8f6 to
b443cf0
Compare
|
And docker-py tests... |
|
This was removed from the API, but maybe needs to be added for older API versions?
|
|
Opened docker/docker-py#1162 to address calls to |
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
b443cf0 to
6d98e34
Compare
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
|
Ok, this is updated with the new docker-py bump, looks like all issues are resolved. |
|
LGTM |
|
LGTM 👼 |
shin-
pushed a commit
to docker/docker-py
that referenced
this pull request
Aug 17, 2016
Docker no longer has an `ExecutionDriver` as of Docker 1.11. The field in the `docker info` API will not be present in 1.13. Found this while working on moby/moby#25721 Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This was referenced Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revendoring engine-api separate of any PR because changes required just to make docker compile are too numerous for other PR's to have to implement.