Decoder does not work properly with nested pointers using gcc #13218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brahmaroutu it might be good to see if we can get rid of hostConfigWrapper entirely since it seems like its not really used for much if we do this PR. |
2f66887 to
b5560d7
Compare
|
@duglin As per your comments, cleaned up the code and removed hostConfigWrapper |
7a031b3 to
73b6759
Compare
| func (c ContainerConfigWrapper) HostConfig() *HostConfig { | ||
| if c.hostConfigWrapper == nil { | ||
| return new(HostConfig) | ||
| func (w ContainerConfigWrapper) GetHostConfig() *HostConfig { |
There was a problem hiding this comment.
Should be w *ContainerConfigWrapper
3f1911d to
94a49bd
Compare
|
@LK4D4 Thanks for the review I updated code. |
94a49bd to
aec411c
Compare
aec411c to
ae6724e
Compare
Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
ae6724e to
eb97de7
Compare
|
LGTM |
calavera
added a commit
that referenced
this pull request
Jun 18, 2015
Decoder does not work properly with nested pointers using gcc
This was referenced Jul 23, 2015
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the runconfig/config_test TestDecodeContainerConfig test is failing when compiled with gccgo. There is a bug files with gccgo specifically to address the decoder issue. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66138
I believe there is no reason to add these fields to the top level structure and hence this PR.
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com