No options to tmpfs is valid #18855
Merged
No options to tmpfs is valid #18855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes at least part of #18853 |
|
@rhatdan Can we have test for this? |
If you run a docker run command with --tmpfs /mountpoint:noexec Or certain options that get translated into mount options, the mount command can get passed "" for mount data. So this should be valid. Signed-off-by: Dan Walsh <dwalsh@redhat.com>
c122590 to
89a775d
Compare
|
Added a test for Which was causing issues. |
|
@rhatdan Thanks |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Walsh dwalsh@redhat.com