-
Notifications
You must be signed in to change notification settings - Fork 18.8k
Version exec json check. #17313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version exec json check. #17313
Conversation
I added this to the milestone because it's a bug we introduced in master recently. |
I don't think this bug was in 1.9.0 unless we do indeed want to check for json in 1.9. |
I remember the pr which introduced this check |
@cpuguy83 you're right, this is not in 1.9. |
LGTM, thanks @calavera |
Need to bump the API version in the version check. |
oh cr*p you're right #etoomanyversions |
802850e
to
9d97fdf
Compare
fixed, thanks! |
Sorry, one more thing... Test for pre 1.22 behavior? |
Keep backwards compatibility with old versions of the api. Signed-off-by: David Calavera <david.calavera@gmail.com>
9d97fdf
to
0b5e628
Compare
I added a test to check that we keep backwards compatibility.
@cpuguy83 it looks like we had already a test sending "application/json" content types to the start endpoint. It didn't fail before because the didn't check the content type, and it didn't fail when we forced it with All in all, this ensures we keep backwards compatibility and adds a test to verify it. We already have a test that checks the current valid behavior. |
LGTM |
1 similar comment
LGTM |
Version exec json check.
exec
against a docker daemon built from master fails #17288Signed-off-by: David Calavera david.calavera@gmail.com