Keep backwards compatibility in kill api. #15098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated the issue number, I think this is the one you meant. |
| @@ -87,3 +89,12 @@ func (s *DockerSuite) TestKillWithInvalidSignal(c *check.C) { | |||
| c.Fatal("Container should be in running state after an invalid signal") | |||
| } | |||
| } | |||
|
|
|||
| func (s *DockerSuite) TestKillofStoppedContainerOldAPI(c *check.C) { | |||
There was a problem hiding this comment.
instead of OldApi, can we specify either 119 or Pre120
|
@thaJeztah issue number now refers to this PR LGTM other than being specific about API versions in the test name. |
|
@cpuguy83 oh darn! the previous number was a non existing issue, but was 10000 off of the PR that introduced this. Probably had the wrong issue on my clipboard, I'll search the right one. |
|
third time's a charm, think I got the right one now. Thanks Brian |
Return an error when the container is stopped only in api versions equal or greater than 1.20 (docker 1.8). Signed-off-by: David Calavera <david.calavera@gmail.com>
b58f9c7 to
621e3d8
Compare
|
Test name fixed. Thank you guys! |
|
LGTM (jankies are running) |
|
LGTM |
|
LGTM |
|
Green janky: merging. |
icecrime
pushed a commit
that referenced
this pull request
Jul 29, 2015
Keep backwards compatibility in kill api.
|
cherry picked into #15091 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return an error when the container is stopped only in api versions
equal or greater than 1.20 (docker 1.8).
Signed-off-by: David Calavera david.calavera@gmail.com