-
Notifications
You must be signed in to change notification settings - Fork 18.8k
Update vendored distribution repo to new version #15034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vendored distribution repo to new version #15034
Conversation
This version includes a fix that avoids checking against specific HTTP status codes. The previous behavior violated the registry API spec. Fixes moby#14975 Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
cc @docker/distribution-maintainers |
This sounds reasonable to add to 1.8 but it looks like we're also adding some new logic in that |
As far as I know, it's not necessary. It's there because I'm updating distribution to the latest master. It would be possible to branch from the earlier revision and apply only the HTTP status code change, if that's something we want to consider. |
It is not necessary, the client does not currently call |
Does anyone know why the tests are failing? I see failures like the following which don't have an obvious connection to updating the dependency:
|
This error occurs when the UUID library is unable to get enough random bits due to entropy exhaustion |
@calavera IIRC this is a code path that the engine does not use (for the registry soft-delete feature), but I'll let @RichardScothern & @aaronlehmann confirm that this indeed has no effect. |
Our CI is gone fishing. Otherwise LGTM! |
Waiting from green tests. |
failed on /dev/urandom... le sighhhh, but merging |
Update vendored distribution repo to new version
This version includes a fix that avoids checking against specific HTTP
status codes. The previous behavior violated the registry API spec.
Fixes #14975
Signed-off-by: Aaron Lehmann aaron.lehmann@docker.com