Skip to content

Conversation

crazy-max
Copy link
Member

Follow up #1824

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max crazy-max force-pushed the ghactions-test branch 2 times, most recently from 566e472 to 4674844 Compare November 22, 2020 02:58
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@codecov-io
Copy link

codecov-io commented Nov 22, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f30fab2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1831   +/-   ##
=========================================
  Coverage          ?   44.49%           
=========================================
  Files             ?      152           
  Lines             ?    15281           
  Branches          ?        0           
=========================================
  Hits              ?     6799           
  Misses            ?     7501           
  Partials          ?      981           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30fab2...1357821. Read the comment docs.

@crazy-max crazy-max marked this pull request as ready for review November 22, 2020 04:01
@crazy-max crazy-max requested a review from tonistiigi November 22, 2020 04:01
@crazy-max crazy-max force-pushed the ghactions-test branch 2 times, most recently from cc1f4e1 to a0f29f5 Compare November 22, 2020 07:16
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

Same test failed (see #1824 (comment)).

@crazy-max crazy-max requested a review from tonistiigi November 22, 2020 08:26
@tonistiigi
Copy link
Member

Frontend tests took 17min in this run. If this is common then probably makes sense to split it up by workers in follow-up.

@tonistiigi tonistiigi merged commit 2a25df5 into moby:master Nov 22, 2020
@crazy-max crazy-max deleted the ghactions-test branch November 22, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants