Skip to content

Refactor validate for GitHub Actions #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2020
Merged

Refactor validate for GitHub Actions #1824

merged 1 commit into from
Nov 21, 2020

Conversation

crazy-max
Copy link
Member

First part of #1821

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max crazy-max requested a review from tonistiigi November 21, 2020 05:08
tonistiigi
tonistiigi reviewed Nov 21, 2020
View reviewed changes
tonistiigi
tonistiigi reviewed Nov 21, 2020
View reviewed changes
tonistiigi
tonistiigi reviewed Nov 21, 2020
View reviewed changes
tonistiigi
tonistiigi reviewed Nov 21, 2020
View reviewed changes
@crazy-max crazy-max force-pushed the ghactions-validate branch 8 times, most recently from bd5820d to 25ec1eb Compare November 21, 2020 05:57
tonistiigi
tonistiigi reviewed Nov 21, 2020
View reviewed changes
tonistiigi
tonistiigi reviewed Nov 21, 2020
View reviewed changes
@crazy-max crazy-max requested a review from tonistiigi November 21, 2020 06:42
tonistiigi
tonistiigi reviewed Nov 21, 2020
View reviewed changes
@crazy-max crazy-max force-pushed the ghactions-validate branch 2 times, most recently from 437aa12 to f1d0c92 Compare November 21, 2020 07:20
@crazy-max crazy-max requested a review from tonistiigi November 21, 2020 07:24
@tonistiigi
Copy link
Member 

�[0K$ ./hack/validate-vendor
+docker buildx build --target validate --file ./hack/dockerfiles/vendor.Dockerfile . --progress=plain
unknown flag: --target
See 'docker --help'.

Usage:	docker [OPTIONS] COMMAND

@crazy-max
Copy link
Member Author

@tonistiigi TestClientGatewayIntegration/TestClientGatewaySlowCacheExecError/worker=containerd-1.3 failed. Linked to #1827.

tiborvass
tiborvass reviewed Nov 21, 2020
View reviewed changes
@crazy-max
Refactor validate for GitHub Actions
a571db4 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
tiborvass
tiborvass approved these changes Nov 21, 2020
View reviewed changes
Copy link
Collaborator

@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remove the validate scripts from .travis.yml in a followup.

@tiborvass tiborvass merged commit 1fbb7a0 into moby:master Nov 21, 2020
@crazy-max crazy-max deleted the ghactions-validate branch November 21, 2020 20:59
This was referenced Nov 21, 2020
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@tiborvass tiborvass tiborvass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crazy-max @tonistiigi @tiborvass