Refactor release for GitHub Actions #1835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1835 +/- ##
==========================================
- Coverage 46.46% 46.22% -0.24%
==========================================
Files 152 152
Lines 15281 15281
==========================================
- Hits 7100 7064 -36
- Misses 7146 7191 +45
+ Partials 1035 1026 -9
Continue to review full report at Codecov.
|
d44336e to
5cb8559
Compare
tonistiigi
reviewed
Nov 24, 2020
|
I just hit rebuild on this action and lot of binaries and dockerfile steps were rebuilt. Eg. in cross and in tests. Looks like caching is not correct, including dependencies like #1833 (comment) . Don't need to block on this but that part seems to need some more work. |
tonistiigi
reviewed
Nov 24, 2020
tonistiigi
reviewed
Nov 24, 2020
a9979a1 to
c7acbd8
Compare
c7acbd8 to
6275059
Compare
6275059 to
b878e7c
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
7b3ebc4 to
d56ddcc
Compare
d8af3bf to
7576470
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
7576470 to
40bcfab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #1824
Push is disabled until we have migrated to GitHub Actions. Once we have migrated to GitHub we will need to add the following secrets to push to Docker Hub:
DOCKERHUB_USERNAMEDOCKERHUB_TOKENSigned-off-by: CrazyMax crazy-max@users.noreply.github.com