tests: client: skip flaky test on windows #5980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still investigating `testCachedMounts`, skipping for now to avoid blocking the CI. ref: moby#5906 Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
|
|
billywr
approved these changes
May 19, 2025
tonistiigi
approved these changes
May 19, 2025
profnandaa
added a commit
to profnandaa/buildkit
that referenced
this pull request
May 20, 2025
Fixes moby#5906, reverts moby#5980 Occasionally, the privilege disabling deffered call is executed before some kernel-side operations are complete. We therefore end up with some access denied errors in `prepareDigest` -> `os.Open()`. Fix this by taking the call closer to where the privileged operation takes place, but outside the recursion for optimal calls. Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa
added a commit
to profnandaa/buildkit
that referenced
this pull request
May 23, 2025
Fixes moby#5906, reverts moby#5980 Previously, due to lack of a sync mechanism, we'd end up with some race condition (occassionally) due to one deferred disableProcessPrivileges call happening before the rest complete. Fix this by introducing a mutex to coordinate the enabling and disabling of the privileges. Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa
added a commit
to profnandaa/buildkit
that referenced
this pull request
May 23, 2025
Fixes moby#5906, reverts moby#5980 Previously, due to lack of a sync mechanism, we'd end up with some race condition (occassionally) due to one deferred disableProcessPrivileges call happening before the rest complete. Fix this by introducing a mutex to coordinate the enabling and disabling of the privileges. Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa
added a commit
to profnandaa/buildkit
that referenced
this pull request
May 23, 2025
Fixes moby#5906, reverts moby#5980 Previously, due to lack of a sync mechanism, we'd end up with some race condition (occassionally) due to one deferred disableProcessPrivileges call happening before the rest complete. Fix this by introducing a mutex to coordinate the enabling and disabling of the privileges. Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still investigating
testCachedMounts, skipping for now to avoid blocking the CI.ref: #5906