feat!: require jsdoc 4.x #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67b31f1 to
8cbd8bc
Compare
8cbd8bc to
5762337
Compare
There was a problem hiding this comment.
😕 there are a lot of formatting changes to this that make it hard to review. Would you be up for splitting those out? Or just committing them to main and then merging/rebasing this branch?
There was a problem hiding this comment.
Ugh, this is prettier that autoapplied the formatting, the only change I did was the import at the very top
KoenDG
added a commit
to KoenDG/mocha-docdash
that referenced
this pull request
Jul 20, 2025
It was stated publish.js had too many changes. I went over them, they were all whitespace changes. Reverted them all, only the change to jsdoc/taffydb remains, as is the goal of this PR.
KoenDG
added a commit
to KoenDG/mocha-docdash
that referenced
this pull request
Jul 20, 2025
It was stated publish.js had too many changes. I went over them, they were all whitespace changes. Reverted them all, only the change to jsdoc/taffydb remains, as is the goal of this PR. Update jsdoc/salty to latest version.
KoenDG
added a commit
to KoenDG/mocha-docdash
that referenced
this pull request
Jul 20, 2025
It was stated publish.js had too many changes. I went over them, they were all whitespace changes. Reverted them all, only the change to jsdoc/taffydb remains, as is the goal of this PR. Update jsdoc/salty to latest version. Update jsdoc from 4.0.3 to 4.0.4
KoenDG
added a commit
to KoenDG/mocha-docdash
that referenced
this pull request
Aug 16, 2025
It was stated publish.js had too many changes. I went over them, they were all whitespace changes. Reverted them all, only the change to jsdoc/taffydb remains, as is the goal of this PR. Update jsdoc/salty to latest version. Update jsdoc from 4.0.3 to 4.0.4 Bunch of squashing done while testing reverting the whitespace so the diff is minimal.
|
👋 ping @voxpelli, do you have time for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
As mentioned in the JSDoc 4.0.0 release notes, it no longer depends on taffydb, and I made the needed changes here.