Skip to content

Import ABC from collections.abc explicitly. #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Import ABC from collections.abc explicitly. #2209

merged 1 commit into from
Oct 27, 2020

Conversation

tirkarthi
Copy link
Contributor

This fixes below warning for Python 3.10 compatibility.

  /root/py39-venv/lib/python3.9/site-packages/mkdocs/config/config_options.py:2: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
    from collections import Sequence, namedtuple

@waylan waylan merged commit 72f506d into mkdocs:master Oct 27, 2020
@graingert
Copy link

can we get a release of this on pypi.org? it's blocking uvicorn CI supporting python 3.10

@waylan
Copy link
Member

waylan commented Jun 7, 2021

See #2440.

taratatach added a commit to cozy/cozy.github.io that referenced this pull request Mar 12, 2024
  `mkdocs` v1.0.4 makes use of the `Sequence` class from the
  `collections` module but this class has been deprecated in favor of
  the same class from the `collections.abc` module in Python 3.10 and
  completely removed in Python 3.12.

  This import was fixed in `mkdocs` v1.2.0 (see
  mkdocs/mkdocs#2209).

  Removed use of Sequence in mkdocs/mkdocs#2938
taratatach added a commit to cozy/cozy.github.io that referenced this pull request Mar 13, 2024
  `mkdocs` v1.0.4 makes use of the `Sequence` class from the
  `collections` module but this class has been deprecated in favor of
  the same class from the `collections.abc` module in Python 3.10 and
  completely removed in Python 3.12.

  This import was fixed in `mkdocs` v1.2.0 (see
  mkdocs/mkdocs#2209).

  Removed use of Sequence in mkdocs/mkdocs#2938
taratatach added a commit to cozy/cozy.github.io that referenced this pull request Mar 13, 2024
  `mkdocs` v1.0.4 makes use of the `Sequence` class from the
  `collections` module but this class has been deprecated in favor of
  the same class from the `collections.abc` module in Python 3.10 and
  completely removed in Python 3.12.

  This import was fixed in `mkdocs` v1.2.0 (see
  mkdocs/mkdocs#2209).
taratatach added a commit to cozy/cozy.github.io that referenced this pull request Mar 13, 2024
  `mkdocs` v1.0.4 makes use of the `Sequence` class from the
  `collections` module but this class has been deprecated in favor of
  the same class from the `collections.abc` module in Python 3.10 and
  completely removed in Python 3.12.

  This import was fixed in `mkdocs` v1.2.0 (see
  mkdocs/mkdocs#2209).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants