Skip to content

Remove incorrect usage of typing.AnyStr #6271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Conversation

sobolevn
Copy link
Contributor

Description

Hi! While working on python/mypy#15732 our tools detected a misuse of AnyStr TypeVar (which is quite common). The proper way here is to use @overloads :)

Checklist

  • I have updated tests where applicable.
  • I have added an entry to the CHANGELOG.

sobolevn and others added 2 commits July 21, 2023 10:52
Hi! While working on python/mypy#15732 our tools detected a misuse of AnyStr TypeVar (which is quite common). The proper way here is to use `@overload`s :)
Copy link
Member

@mhils mhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you so much! 🍰

@mhils mhils merged commit cd4c13a into mitmproxy:main Jul 21, 2023
lasting-yang pushed a commit to lasting-yang/mitmproxy that referenced this pull request Aug 2, 2023
* Remove incorrect usage of `typing.AnyStr`

Hi! While working on python/mypy#15732 our tools detected a misuse of AnyStr TypeVar (which is quite common). The proper way here is to use `@overload`s :)

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants