Skip to content

Integrate Volar for the built-in HTML Extension #171547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 103 commits into
base: main
Choose a base branch
from
Open

Integrate Volar for the built-in HTML Extension #171547

wants to merge 103 commits into from
+1,409 −3,477

Conversation

johnsoncodehk
Copy link
Contributor

@johnsoncodehk johnsoncodehk commented Jan 17, 2023 •
edited
Loading

This PR tries to implement html-language-features with Volar.js, which is the framework used by Vue - Official, MDX, Astro behind the scenes. Compared with the original implementation, supporting embedded documents should be much simpler.

Preview Extension: johnsoncodehk#1

Features / Bug Fixes

@johnsoncodehk johnsoncodehk changed the title feat: migrated to @volar/language-server Adopt embedded language framework for HTML extension Jan 17, 2023
@aeschli
Copy link
Contributor

aeschli commented Jan 18, 2023

That's really cool, well architectured.
It would be great if we could switch to such a setup and profit from your work. The main challenge is of course that we would rely on a code base that is all owned by volar. I'll bring it up for discussion with the team here and we see what can be done.

@johnsoncodehk johnsoncodehk mentioned this pull request Feb 8, 2024
Open
42 tasks
@johnsoncodehk johnsoncodehk changed the title Adopt embedded language framework for HTML extension Integrate Volar for HTML Extension Feb 9, 2024
@johnsoncodehk johnsoncodehk changed the title Integrate Volar for HTML Extension Integrate Volar for the built-in HTML Extension Feb 9, 2024
@johnsoncodehk johnsoncodehk mentioned this pull request Feb 20, 2024
Merged
@Princesseuh Princesseuh mentioned this pull request Aug 21, 2024
Open
@laundmo
Copy link

laundmo commented Oct 25, 2024

This would be great to have - was there any decision by the team?

@johnsoncodehk johnsoncodehk mentioned this pull request May 14, 2025
Draft
@johnsoncodehk
Copy link
Contributor Author

If anyone wants to test this, you can find the preview extension here: johnsoncodehk#1

@Sight-wcg Sight-wcg mentioned this pull request Jun 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[html] Support SCSS in HTML with <style type="text/scss"> [html] JSON edit support inside HTML document / script tag with type="application/json" [html] provide rename for embedded JavaScript [html] Javascript intellisense in inline scripts from external references [html] support 'import' in <script type=module> tags
[html] support less syntax in html file [html] don't let '/' trigger a suggest in embedded JavaScript [html] Unecessary warning when script contains quotes on the same line as an onFoo attribute using the same quotes [html] support imports in embedded JavaScript [html] Unexpected "Declaration or statement expected" in HTML code
4 participants
@johnsoncodehk @aeschli @43081j @laundmo