Skip to content

[html] provide rename for embedded JavaScript #31141

@abdonrd

Description

@abdonrd
  • VSCode Version: v1.14.1
  • OS Version: macOS Sierra v10.12.6
  • Reproduces without extensions: Yes

Steps to Reproduce:

  1. Create these two files:

my-custom-element.js

class MyCustomElement extends HTMLElement {
  static get is() {
    return 'my-custom-element';
  }
}

customElements.define(MyCustomElement.is, MyCustomElement);

my-custom-element.html

<script>
  class MyCustomElement extends HTMLElement {
    static get is() {
      return 'my-custom-element';
    }
  }

  customElements.define(MyCustomElement.is, MyCustomElement);
</script>
  1. Try the Rename Refactoring with F2 in both files:

screen shot 2017-07-20 at 17 48 44

screen shot 2017-07-20 at 17 48 57

With the same code, the "Rename Refactoring" doesn't work in HTML language.

Metadata

Metadata

Assignees

Labels

feature-requestRequest for new features or functionalityhelp wantedIssues identified as good community contribution opportunitieshtmlHTML support issuesjavascriptJavaScript support issueskeepIssues we should not close as out of scope

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions