Introduce ISignService #75200
Merged
Introduce ISignService #75200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
approved these changes
Jun 11, 2019
Co-Authored-By: Benjamin Pasero <benjamin.pasero@gmail.com>
…rted multiple times, The ones after the first will not throw an error. And this will break the contract of the sign method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
ISignServiceand provides two implementations: one for the browser and one for node.This PR also adopts the
ISignServicefor theRemoteAgentConnectionand for the Debug handshake.Note that this PR does not change how we actually sign. Just restructures the code such that we have a centralized place where we do this - a service.
Fixes #74398
fyi @weinand @aeschli