Skip to content

move comments to browser (#70319, #69103) #70939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2019
Merged

move comments to browser (#70319, #69103) #70939

merged 2 commits into from
Mar 25, 2019

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Mar 22, 2019

fixes #70319, #69103

@bpasero bpasero added this to the March 2019 milestone Mar 22, 2019
@bpasero bpasero self-assigned this Mar 22, 2019
@bpasero bpasero requested review from rebornix and RMacfarlane March 22, 2019 07:22
RMacfarlane
RMacfarlane approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@RMacfarlane RMacfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bpasero, this looks good to me

@bpasero bpasero merged commit 3c136df into master Mar 25, 2019
@bpasero bpasero deleted the ben/comments-browser branch March 25, 2019 06:56
@RMacfarlane RMacfarlane mentioned this pull request Jul 25, 2019
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix Awaiting requested review from rebornix

1 more reviewer

@RMacfarlane RMacfarlane RMacfarlane approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
March 2019
Development

Successfully merging this pull request may close these issues.

Split up workbench/api into a node and browser part
2 participants
@bpasero @RMacfarlane