Skip to content

Split up workbench/api into a node and browser part #70319

@bpasero

Description

@bpasero

For #68302

We will eventually have to move our vs/workbench/api/electron-browser/mainThread.* files into browser or common to support running extensions without node integration.

When I look at an example (mainThreadLanguages.ts) a common pattern seems to be a dependency to node/extHost.protocol which seems to contain both types for the renderer side as well as the extension host side.

As a first step I would think node/extHost.protocol needs to split up into 2 parts, where the one is clearly the types accessed within the extension host and the other from the renderer side (which then can live in common or browser).

Thoughts?

Metadata

Metadata

Labels

debtCode quality issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions