Skip to content

Remove Uri arg from python API #11605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2022
Merged

Remove Uri arg from python API #11605

merged 1 commit into from
Oct 10, 2022

Conversation

DonJayamanne
Copy link
Contributor

Part of #7583

joyceerhl
joyceerhl approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@joyceerhl joyceerhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few references to the Uri arg in some code that's been commented out (including the notebook functional tests), maybe worth updating if we ever bring those tests back?

@DonJayamanne
Copy link
Contributor Author

arg in some code that's been commented out (including the notebook functional tests), maybe worth updating if we ever bring those tests back?

Thanks, the compiler should pick that up.

@DonJayamanne DonJayamanne merged commit ae99a94 into newPythonAPi Oct 10, 2022
@DonJayamanne DonJayamanne deleted the removeResourceArgFromInterpreterDetails branch October 10, 2022 23:47
DonJayamanne added a commit that referenced this pull request Oct 11, 2022
@DonJayamanne
Adopt the new Python Extension API (#11612)
8b9caf9 
* Changes to Environment Types

* Remove unwanted properties from PythonEnv Version

* Adopt the new Python Api

* Remove unused getInterpreterInfo method

* Add id to PythonEnvironment

* Add id to PythonEnvironment

* Add id to PythonEnvironment

* Remove more unused Python execution methods

* Remove old Python API (#11599)

* Misc

* Remove Uri arg from python API (#11605)

* Remove refs to unused Python API code (#11608)

* Remove refs to unused Python API code

* Fix test

* fixes

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@joyceerhl joyceerhl joyceerhl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @joyceerhl