Using the standard localize function directly #10383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
approved these changes
Jun 8, 2022
sadasant
added a commit
that referenced
this pull request
Jun 13, 2022
* wip * all the API changes in localize.ts, I believe * some of the file changes * wip * reinstating the .nls.*.json files * kernel entries and other stuff * typos * Notebook Renderers * wip * webpack fixes * changing the signature of localize, to match how webpack will replace it * package.nls.json * I do not think vscode-nls-dev actually works with localize( as a string, but only with the message string. Also, vscode-nls config * restoring jupyter.runallcells.title * fixed mistake in CLI command * restoring jupyter.runallcellsabove.title * restoring jupyter.runcellandallbelow.title * restoring jupyter.selectjupyteruri.title * fixing mistakes made by bad automation * more improvements * this change was unnecessary * [Buildable PR copy] Localize using vscode-nls (#10382) * wip * all the API changes in localize.ts, I believe * some of the file changes * wip * reinstating the .nls.*.json files * kernel entries and other stuff * typos * Notebook Renderers * wip * webpack fixes * changing the signature of localize, to match how webpack will replace it * package.nls.json * I do not think vscode-nls-dev actually works with localize( as a string, but only with the message string. Also, vscode-nls config * restoring jupyter.runallcells.title * fixed mistake in CLI command * restoring jupyter.runallcellsabove.title * restoring jupyter.runcellandallbelow.title * restoring jupyter.selectjupyteruri.title * fixing mistakes made by bad automation * more improvements * this change was unnecessary * using the standard localize function directly * Using the standard localize function directly (#10383) * using the standard localize function directly * conditional easier to the eyes * an idea * an idea (#10395) * Fixing bundle destination paths (#10403) * fixed webpack (#10406) * moving the webpack config around (#10407) * restoring the webpack step to be the first, this time with __dirname (#10408) * returning to the old base file approach, but adding an exception on the .vscodeignore (#10411) * Also allowing nls.metadata.header.json (#10412) * adding the whole src to see if that makes a difference (#10414) * Exception in .vscodeignore for nls.bundle.*.json (#10415) * test without clean (#10421) * Localization-tolerant gulp clean (#10423) * Localization-tolerant gulp clean * a bit more general * much cleaner * Better nls.*.json regexes (#10425) * better comment * package.nls.json now has object values -- this fixes localization in the browser * test fix * small changes for consistency * consistent quotes * undoing some unnecessary change * This could be the fix * some polishes that seemed reasonable to me Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the build failed because of how it walks the syntax tree upwards to where their exported function is being used. This PR picks the correct localize function at the beginning of the file, and then uses it directly.