Skip to content

[pcre] fix build failure on s390x #42460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2024
Merged

[pcre] fix build failure on s390x #42460

merged 4 commits into from
Dec 4, 2024

Conversation

msclock
Copy link
Contributor

@msclock msclock commented Dec 1, 2024

Fixes #42459

@msclock msclock force-pushed the pcre branch 3 times, most recently from a54681b to add5ec2 Compare December 1, 2024 09:57
dg0yt
dg0yt reviewed Dec 1, 2024
View reviewed changes
@msclock msclock marked this pull request as draft December 1, 2024 10:11
@msclock msclock changed the title [pcre] fix build failure on s390x/arm [pcre] fix build failure on s390x Dec 1, 2024
@msclock msclock marked this pull request as ready for review December 1, 2024 10:40
@msclock
Copy link
Contributor Author

msclock commented Dec 1, 2024 •
edited
Loading

It is weird and still has conflicts.

@dg0yt
Copy link
Contributor

dg0yt commented Dec 1, 2024

It is not so weird: You started with a commit from August 2023(!). Rebase on HEAD of master.

@msclock
Copy link
Contributor Author

msclock commented Dec 1, 2024

You started with a commit from August 2023(!)

@dg0yt Thanks for pointing out it. Rebased now.

msclock and others added 3 commits December 1, 2024 21:12
@msclock
fix pcre build failure on s390x/arm
04adbd1 
Signed-off-by: l.feng <43399351+msclock@users.noreply.github.com>
@msclock @dg0yt
Update ports/pcre/portfile.cmake
c452641 
Co-authored-by: Kai Pastor <dg0yt@darc.de>
@msclock
Update versions
f125273 
Signed-off-by: l.feng <43399351+msclock@users.noreply.github.com>
@Mengna-Li Mengna-Li added the category:port-bug The issue is with a library, which is something the port should already support label Dec 2, 2024
@BillyONeal BillyONeal merged commit 5deeb36 into microsoft:master Dec 4, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks!

@msclock msclock deleted the pcre branch December 5, 2024 00:14
@Mengna-Li Mengna-Li added the info:reviewed Pull Request changes follow basic guidelines label Dec 5, 2024
msclock added a commit to msclock/cppcheck-wheel that referenced this pull request Dec 23, 2024
@msclock
perf: refine dependency pcre for cppcheck
8e6bb50 
See microsoft/vcpkg#42460

Signed-off-by: l.feng <43399351+msclock@users.noreply.github.com>
@msclock msclock mentioned this pull request Dec 23, 2024
Merged
msclock added a commit to msclock/cppcheck-wheel that referenced this pull request Dec 23, 2024
@msclock
perf(no-release): refine dependency pcre for cppcheck (#121)
8329f8f 
See microsoft/vcpkg#42460

Signed-off-by: l.feng <43399351+msclock@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dg0yt dg0yt dg0yt left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Mengna-Li Mengna-Li

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pcre] Build error on s390x-linux
4 participants
@msclock @dg0yt @BillyONeal @Mengna-Li