[vcpkg] Avoid computing triplet ABIs for editable packages #13446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding a test would require mocking |
I don't mean a unit test, I mean in the e2e tests. |
|
@ras0219 Works as advertised. Thank you! |
…ing by default, and --editable
|
/azp run |
|
No pipelines are associated with this pull request. |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…#13446) * [vcpkg] Avoid computing triplet ABIs for editable packages * [vcpkg] Address PR comments * [vcpkg-end-to-end-tests] Add tests for --no-binarycaching, binarycaching by default, and --editable Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR delays computation of
abi_info.triplet_abiuntil after we perform a check for conditions that would disable computation of a package abi. This can save several seconds in the port inner-dev loop.The specific examples of this case are
--editableand--head, which will both disable our ability to compute ABIs. Furthermore, if a package without an ABI is installed, all transitive consumers also cannot have their ABIs computed.Before:
After:
+@qis who may be particularly happy about this change :)