[vcpkg] Fix upgrade for port-version #13069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code only checked the version, whereas we should be checking both Fixes microsoft#12796 cc @cenit
|
Was |
ras0219
approved these changes
Aug 21, 2020
|
How do you like BillyONeal@2acaf72 ? |
|
@ras0219 yeah it was fixed previously. |
|
CI failure fixed by #13087 |
JackBoosY
approved these changes
Aug 24, 2020
PhoebeHui
approved these changes
Aug 24, 2020
|
Nicole asked me to push my edits to this PR out of line. |
|
The fluidsynth failure is fixed by #13125 ; I won't wait for a clean build here if that's the only failure since there's no point. |
|
Thanks for your help! |
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
Co-authored-by: Billy Robert O'Neal <bion@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code only checked the version, whereas we should be checking both
Fixes #12796
cc @cenit