Skip to content

Conversation

Ghabry
Copy link
Contributor

@Ghabry Ghabry commented Aug 19, 2020

  • What does your PR fix?

It adds a new library "fluidlite".

Biggest advantage: No dependency on glib. Actually no single dependency. Perfect when you just want to work with Soundfonts.

Fluidlite has a API compatible to Fluidsynth but it lacks some features: No built-in audio player, no MIDI file parser. So the main purpose is sampling audio provided by an external midi sequencer library.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

I tested x86-windows, x64-windows and x64-windows-static.

The CMakeLists builds on Linux and macOS, but not tested through vcpkg.

No idea what a CI baseline is.

I think so.

I have a question:
The library has no versions, I just used the latest master commit as a version. Is this okay or how is the procedure?

@Ghabry Ghabry mentioned this pull request Aug 19, 2020
1 task
@NancyLi1013 NancyLi1013 self-assigned this Aug 20, 2020
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

Hi @Ghabry
Thanks for this PR.
There are some regressions on x64-uwp and arm-uwp. Could you please look into them?

@NancyLi1013 NancyLi1013 added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Aug 20, 2020
@Ghabry
Copy link
Contributor Author

Ghabry commented Aug 20, 2020

Ignore my "XXX" commits they are just for testing because I can't get UWP installed locally (Internet too slow, Download takes days).
I will try to fix them and then submit a patch upstream. Will tell you when I'm ready :)

@Ghabry
Copy link
Contributor Author

Ghabry commented Aug 20, 2020

@NancyLi1013
I upstreamed a patch for UWP so this should be good to go :)

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 21, 2020
@NancyLi1013
Copy link
Contributor

@Ghabry
LGTM now. Thanks for your efforts.

@BillyONeal BillyONeal merged commit 4477888 into microsoft:master Aug 21, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Aug 25, 2020
Fluidlite, added 3 days ago in microsoft#13006 , tries to install the same files as fluidsynth; it's similar to the 'boringssl' situation. Given that fluidlite doens't have any dependencies, this change disables that one rather than fluidsynth,
BillyONeal added a commit that referenced this pull request Aug 25, 2020
* Disable fluidlite in CI.

Fluidlite, added 3 days ago in #13006 , tries to install the same files as fluidsynth; it's similar to the 'boringssl' situation. Given that fluidlite doens't have any dependencies, this change disables that one rather than fluidsynth,

* Add warning message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants