Skip to content

[vcpkg] Fix build on older compilers. #12950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2020
Merged

[vcpkg] Fix build on older compilers. #12950

merged 1 commit into from
Aug 25, 2020

Conversation

huahang
Copy link
Contributor

@huahang huahang commented Aug 17, 2020

Describe the pull request

Signed-off-by: Hans hans@dkmt.io

@ghost
Copy link

ghost commented Aug 17, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@NancyLi1013 NancyLi1013 self-assigned this Aug 17, 2020
@NancyLi1013 NancyLi1013 added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Aug 17, 2020
@NancyLi1013 NancyLi1013 changed the title Fix build on older compilers. [vcpkg] Fix build on older compilers. Aug 17, 2020
@huahang
Fix build on old compilers.
44ee163 
Signed-off-by: Hans <hans@dkmt.io>
@ras0219
Copy link
Contributor

ras0219 commented Aug 17, 2020

Hi @huahang; could you specifically mention which compiler versions this change enables? We also require the C++ Filesystem TS which imposes an additional minimum requirement.

@huahang
Copy link
Contributor Author

huahang commented Aug 19, 2020

Hi @huahang; could you specifically mention which compiler versions this change enables? We also require the C++ Filesystem TS which imposes an additional minimum requirement.

The specific compiler I am using is clang-7 in debian 9. C++ Filesystem TS works fine. It just lacks support of std::is_const_v and std::is_reference_v.

The command I use to build vcpkg is:
CC=clang-7 CXX=clang++-7 ./bootstrap-vcpkg.sh

@huahang
Copy link
Contributor Author

huahang commented Aug 24, 2020

Hi @huahang; could you specifically mention which compiler versions this change enables? We also require the C++ Filesystem TS which imposes an additional minimum requirement.

The specific compiler I am using is clang-7 in debian 9. C++ Filesystem TS works fine. It just lacks support of std::is_const_v and std::is_reference_v.

The command I use to build vcpkg is:
CC=clang-7 CXX=clang++-7 ./bootstrap-vcpkg.sh

@ras0219 @JackBoosY
Hi, the author has responded. Is there any update?
:-)

@JackBoosY JackBoosY requested review from strega-nil, ras0219-msft and BillyONeal and removed request for strega-nil August 25, 2020 01:07
@BillyONeal BillyONeal merged commit 99b0756 into microsoft:master Aug 25, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 25, 2020
@huahang @remz1337
[vcpkg] Fix build on old compilers. (microsoft#12950)
c5561c0
@lebdron lebdron mentioned this pull request Jan 10, 2021
Closed
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@huahang
[vcpkg] Fix build on old compilers. (microsoft#12950)
f24b34d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

@BillyONeal BillyONeal Awaiting requested review from BillyONeal

Assignees

@NancyLi1013 NancyLi1013

@JackBoosY JackBoosY

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huahang @ras0219 @BillyONeal @NancyLi1013 @JackBoosY