Skip to content

[vcpkg baseline] Fix openimageio and pangolin build failures on Linux #12856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2020
Merged

[vcpkg baseline] Fix openimageio and pangolin build failures on Linux #12856

merged 3 commits into from
Aug 12, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Aug 11, 2020 •
edited
Loading

For openimageio:

/mnt/vcpkg-ci/buildtrees/openimageio/src/9c73ea82cc-f088f982ce.clean/src/heif.imageio/heifinput.cpp:8:10: fatal error: libheif/heif_cxx.h: No such file or directory
 #include <libheif/heif_cxx.h>
          ^~~~~~~~~~~~~~~~~~~~

This need to add libheif to the dependency list and install this extra headers.

For pangolin:

: && /usr/bin/c++  -std=c++0x -Wall -Wextra -fPIC -g  -rdynamic examples/SharedMemoryVideoWriter/CMakeFiles/SharedMemoryVideoWriter.dir/main.cpp.o  -o examples/SharedMemoryVideoWriter/SharedMemoryVideoWriter  src/libpangolin.a  -lrt  -lpthread  -lGL  -lGLU  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libGLEWd.a  -lSM  -lICE  -lX11  -lXext  /mnt/vcpkg-ci/installed/x64-linux/lib/libpython3.8.a  -ldl  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libavformat.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libavdevice.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libavcodec.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libavutil.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libswscale.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libswresample.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libpng16d.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libz.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libjpeg.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libtiffd.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/liblzmad.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libz.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libjpeg.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/libtiffd.a  /mnt/vcpkg-ci/installed/x64-linux/debug/lib/liblzmad.a  -lm && :
/mnt/vcpkg-ci/installed/x64-linux/lib/libpython3.8.a(posixmodule.o): In function `os_openpty_impl':
/mnt/vcpkg-ci/buildtrees/python3/src/v3.8.3-43b03f2bf0.clean-x64-linux-release/./Modules/posixmodule.c:6683: undefined reference to `openpty'

This is caused by not adding the libutil library in the Linux system when pangolin uses python.

Related: #12672 #11836 #10132 etc.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Aug 11, 2020
@JackBoosY JackBoosY changed the title [vcpkg baseline] Fix openimageio and pangolin build failures [vcpkg baseline] Fix openimageio and pangolin build failures on Linux Aug 11, 2020
@JackBoosY JackBoosY requested a review from PhoebeHui August 11, 2020 08:43
@JackBoosY
Copy link
Contributor Author

@strega-nil If you have no worries, please consider merging this PR first.

@LilyWangL LilyWangL mentioned this pull request Aug 12, 2020
Closed
@LilyWangL LilyWangL mentioned this pull request Aug 12, 2020
Merged
@ras0219
Copy link
Contributor

ras0219 commented Aug 12, 2020

In a separate PR, we should also seek to control whether pangolin is using python via a feature -- some sort of pangolin[python] that will otherwise suppress the python check via -DCMAKE_DISABLE_FIND_PACKAGE_PythonLibs=ON.

Roughly

vcpkg_check_features(
  ...
  INVERTED_FEATURES python CMAKE_DISABLE_FIND_PACKAGE_PythonLibs
)

The python feature would then also Build-Depends: on python3.

@strega-nil strega-nil merged commit 9a75137 into microsoft:master Aug 12, 2020
@JackBoosY JackBoosY deleted the dev/jack/fix_baseline_20200811 branch August 12, 2020 16:49
remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
@JackBoosY @remz1337
[vcpkg baseline] Fix openimageio and pangolin build failures on Linux (…
764fe53 
…microsoft#12856)

* [openimageio] Add dependency libheif

* [pangolin] Fix link to linux system lib libutil

* [libheif] Install extra headers for other ports(oiio)
@JackBoosY JackBoosY mentioned this pull request Aug 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

+1 more reviewer

@ras0219 ras0219 ras0219 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackBoosY @ras0219 @PhoebeHui @strega-nil