Skip to content

Conversation

arves100
Copy link
Contributor

@arves100 arves100 commented Aug 1, 2020

Under FreeBSD 11.3 with GCC 9 x86, noone of the x86 macro are defined making vcpkg impossible to build.
This commit adds i386 as list of possible macros in order to allow vcpkg to be built.

@PhoebeHui PhoebeHui self-assigned this Aug 3, 2020
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines labels Aug 3, 2020
@strega-nil strega-nil merged commit e79a4f3 into microsoft:master Aug 5, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants