Skip to content

[mpir, gmp] Add message to handle the conflicts between these two ports #12664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2020
Merged

[mpir, gmp] Add message to handle the conflicts between these two ports #12664

merged 1 commit into from
Aug 5, 2020

Conversation

NancyLi1013
Copy link
Contributor

Both mpir and gmp will install gmp.h and gmpxx.h to include/ directory when building these two ports. Since these two files are different in each port.

Also update vcpkg.json for gmp.

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jul 31, 2020
@JackBoosY JackBoosY marked this pull request as ready for review August 3, 2020 02:11
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 3, 2020
@JackBoosY JackBoosY changed the title [mpir, gmp] Add message to handle the conflicts between these two ports. [mpir, gmp] Add message to handle the conflicts between these two ports Aug 3, 2020
@strega-nil strega-nil merged commit 1ed263b into microsoft:master Aug 5, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@NancyLi1013 @hellozee
[mpir, gmp] Add message to handle the conflicts between these two por…
5513926 
…ts. (microsoft#12664)
@cuirq3 cuirq3 mentioned this pull request Apr 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gmp] and [mpir] have irreconcilable conflicts
3 participants
@NancyLi1013 @JackBoosY @strega-nil