Fix .gitignore excluding triplets/community, sort, and driveby vcpkg_check_linkage.md doc bug. #12624
Conversation
…n .gitignore'd triplets.
.gitignore
Outdated
| !triplets/x64-osx.cmake | ||
| !/triplets/arm-uwp.cmake | ||
| !/triplets/arm64-windows.cmake | ||
| !/triplets/community |
There was a problem hiding this comment.
These should be after the other "official" triplets, imo, and also we shouldn't need to explicitly unignore all the files underneath /triplets/community.
There was a problem hiding this comment.
These should be after the other "official" triplets, imo,
I really really like being able to highlight the whole block and press F9. If you want this moved I think you should suggest a rule we can apply consistently rather than cite an individual example. I don't think reordering this anywhere will make it clearer.
also we shouldn't need to explicitly unignore all the files underneath
/triplets/community
OK but if we add everything in there why are we .gitignoring anything? I really don't understand why the triplets were .gitignore'd in the first place, I don't think they should be.
There was a problem hiding this comment.
It allows a user to define their own triplets.
I'm saying you don't need to explicitly unignore all files underneath /triplets/community because you've unignored /triplets/community -- thus, they're already unignored.
There was a problem hiding this comment.
It allows a user to define their own triplets.
I don't see how the .gitignore has any bearing on the ability to do this.
I'm saying you don't need to explicitly unignore all files underneath /triplets/community because you've unignored /triplets/community -- thus, they're already unignored.
Hmmmmmmmm that's not what I remember observing but I can check again.
There was a problem hiding this comment.
Or, you could unignore /triplets/community/*; a user should be placing their triplets under /triplets, imo
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
|
Given that this only modifies |
…y vcpkg_check_linkage.md doc bug. (microsoft#12624) * Un-.gitignore /triplets/community and use an absolute glob for all non .gitignore'd triplets. * Fix vcpkg_check_linkage.md example to a port that actually uses vcpkg_check_linkage. * Exclude all of the community directory. * Update .gitignore Co-authored-by: nicole mazzuca <mazzucan@outlook.com> Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
No description provided.