[neargye-semver] Add new port #12406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
requested changes
Jul 13, 2020
There was a problem hiding this comment.
Thanks for the PR!
Because this name is quite generic and the library doesn't seem broadly established, a more specialized name would be preferable (perhaps Neargye-semver).
Additionally, semver.hpp is somewhat likely to conflict with existing source code that might have a private "semver.hpp"; please consider moving the header to include/neargye/semver.hpp
Another library with an extremely similar name: https://github.com/h2non/semver.c
- Also moved the header file into a subdirectory.
|
Thanks for the comment. I updated the pull request. |
ras0219-msft
approved these changes
Jul 14, 2020
PhoebeHui
approved these changes
Jul 16, 2020
hellozee
pushed a commit
to hellozee/vcpkg
that referenced
this pull request
Sep 11, 2020
* [semver] Add new port * [neargye-semver] Changed port name to a more specific neargye-semver. - Also moved the header file into a subdirectory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new single file header-only library.