Skip to content

[Open3D] add new port, with its many dependencies #12199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 73 commits into from
Closed

[Open3D] add new port, with its many dependencies #12199

wants to merge 73 commits into from

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Jul 1, 2020 •
edited
Loading

Fixes: #11950
Fixes: #6158
Fixes: #9172

Open3D has many dependencies, primarily it requires filament, which in turn has many sub-dependencies, in particular it requires a proper working assimp library. And so on... (assimp was distributing so many 3rd party libs within itself...)

notes from this PR (but both ports involved are already in master, I am not adding problems, just noting them here)

  • qhull port is malformed, it requires to build both static & dynamic libraries in order to have a working cmake target file
  • pybind11 port seems broken, or at least i don't know how to use it. Any find_package(pybind11) returns an error, being able to find only the Python interpreter but not the libs.

@cenit cenit changed the title [Open3D] scaffolding for port [Open3D] add new port Jul 6, 2020
@cenit cenit marked this pull request as ready for review July 6, 2020 02:55
NancyLi1013
NancyLi1013 suggested changes Jul 10, 2020
View reviewed changes
@NancyLi1013 NancyLi1013 added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Jul 10, 2020
cenit and others added 7 commits July 13, 2020 21:39
@cenit @NancyLi1013
Update ports/glew/CONTROL
9f1d6e3 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@cenit @NancyLi1013
Update ports/gtest/CONTROL
da6ced8 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@cenit @NancyLi1013
Update ports/qhull/CONTROL
0a82ec1 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@cenit @NancyLi1013
Update ports/tinygltf/CONTROL
aba2738 
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@cenit
Merge branch 'master' into dev/cenit/open3d
e4ebb1e
@cenit
[filament] add new port
4bffb2f
@cenit
[open3d] improve port
c42b126
@cenit cenit marked this pull request as draft July 16, 2020 21:58
@cenit cenit changed the title [Open3D] add new port [Open3D] add new port, [filament] add new port, too! Jul 16, 2020
@pablospe
Copy link
Contributor

pablospe commented Nov 13, 2020 •
edited
Loading

It is required yes, the main goal of this pr was open3d and open3d is still not available on master.

Hopefully you can fix the conflicts and the PR will be one step closer to be accepted. It would be super useful to have open3d in vcpkg.

@NancyLi1013
Copy link
Contributor

@cenit

Could you please resolve the conflicts and merge master branch? Since some changes have been merged to master.

@cenit
Copy link
Contributor Author

cenit commented Nov 16, 2020

@NancyLi1013 I did an automatic merge. Maybe I will have to revisit the whole PR later to check if it's still ok

@NancyLi1013
Copy link
Contributor

Open3d failed on x64-windows

CMake Error at C:/a/2/s/scripts/buildsystems/vcpkg.cmake:480 (_add_library):
  Target "Open3D" links to target "Qhull::qhullstatic" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Call Stack (most recent call first):
  src/Open3D/CMakeLists.txt:52 (add_library)


CMake Error at C:/a/2/s/scripts/buildsystems/vcpkg.cmake:480 (_add_library):
  Target "Open3D" links to target "Qhull::qhullstatic_r" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  src/Open3D/CMakeLists.txt:52 (add_library)


CMake Error at C:/a/2/s/scripts/buildsystems/vcpkg.cmake:445 (_add_executable):
  Target "ConvertPointCloud" links to target "Qhull::qhullstatic" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
  src/Tools/CMakeLists.txt:4 (add_executable)
  src/Tools/CMakeLists.txt:15 (TOOL)


CMake Error at C:/a/2/s/scripts/buildsystems/vcpkg.cmake:445 (_add_executable):
  Target "ConvertPointCloud" links to target "Qhull::qhullstatic_r" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?
Call Stack (most recent call first):
  src/Tools/CMakeLists.txt:4 (add_executable)
  src/Tools/CMakeLists.txt:15 (TOOL)

NancyLi1013
NancyLi1013 reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port-Version should be updated for these port:
glew, libzip, qt5-location, robin-map

For gtest, I noticed that you only removed its usge. Is this change related to this PR?

@NancyLi1013
Copy link
Contributor

New conflicts need to resolve @cenit.

@cenit
Copy link
Contributor Author

cenit commented Dec 7, 2020

Merged with master and bumped requested ports.
As before, maybe a full PR revision might be due. Unfortunately I have zero time to do that, very very sorry

@cenit
Copy link
Contributor Author

cenit commented Dec 7, 2020

from a quick check, I saw that IRRxml has been superseded with the whole irrlicht engine.
This looks very surprising to me, TBH. It should have been the opposite, with irrlicht depending on irrxml...
Irrlicht CMakeLists.txt is broken on osx (and it would require vcpkg to support ObjectiveC++ to enable it...), so any progress on this PR might depend on a reversal of the irrxml deprecation...

@cenit cenit mentioned this pull request Feb 1, 2021
Closed
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 19, 2021
Merged
Merged
Merged
Closed
Merged
Merged
Closed
@NancyLi1013
Copy link
Contributor

Maybe this PR can be closed now. @cenit

@cenit cenit closed this Apr 23, 2021
@VegetableWithChicken
Copy link

Open3D is supported????
vcpkg.exe install Open3d:x64-windows

@cenit
Copy link
Contributor Author

cenit commented Aug 13, 2021

nope, work is continued in #17423

@JackBoosY JackBoosY reopened this Aug 16, 2021
@JackBoosY JackBoosY closed this Aug 16, 2021
@aminya aminya mentioned this pull request Oct 31, 2024
Draft
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@NancyLi1013 NancyLi1013

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Port Request] Open3D [New Port Request] <open3d> I could not find Open3D by vcpkg search command.
8 participants
@cenit @NancyLi1013 @JackBoosY @Neumann-A @ras0219 @pablospe @VegetableWithChicken @ras0219-msft