[Open3d] new port #17423

fran6co · 2021-04-21T15:38:31Z

This is a rework of #12199

Depends on:

I disabled the GUI for now, I will enable it when I get filament working with it

ports/poissonrecon/CONTROL

ports/tinygltf/portfile.cmake

ports/poissonrecon/intel-isl.patch

ports/poissonrecon/CMakeLists.txt

NancyLi1013 · 2021-05-11T01:10:13Z

Open3d failed with the following errors:

-- Found PythonInterp: D:/installed/x86-windows/tools/python3/python.exe (found version "3.9.2") 
CMake Error at D:/installed/x86-windows/share/pybind11/FindPythonLibsNew.cmake:210 (message):
  Python libraries not found
Call Stack (most recent call first):
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  D:/installed/x86-windows/share/pybind11/pybind11Tools.cmake:38 (find_package)
  D:/installed/x86-windows/share/pybind11/pybind11Common.cmake:195 (include)
  D:/installed/x86-windows/share/pybind11/pybind11Config.cmake:249 (include)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  3rdparty/find_dependencies.cmake:726 (find_package)
  CMakeLists.txt:444 (include)

fran6co · 2021-05-11T05:10:29Z

Open3d failed with the following errors:


-- Found PythonInterp: D:/installed/x86-windows/tools/python3/python.exe (found version "3.9.2") 

CMake Error at D:/installed/x86-windows/share/pybind11/FindPythonLibsNew.cmake:210 (message):

  Python libraries not found

Call Stack (most recent call first):

  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)

  D:/installed/x86-windows/share/pybind11/pybind11Tools.cmake:38 (find_package)

  D:/installed/x86-windows/share/pybind11/pybind11Common.cmake:195 (include)

  D:/installed/x86-windows/share/pybind11/pybind11Config.cmake:249 (include)

  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)

  3rdparty/find_dependencies.cmake:726 (find_package)

  CMakeLists.txt:444 (include)

It looks to be pybind11 not finding python. I couldn't get to build python with the latest vcpkg on windows, could that be related?

ssheorey · 2021-05-13T21:01:40Z

@fran6co Open3D doesn't support Python 3.9.x as yet. Only 3.6-3.8.

JackBoosY · 2021-05-25T09:06:09Z

@fran6co Open3D doesn't support Python 3.9.x as yet. Only 3.6-3.8.

If it's true, we should wait for the upstream to support newer Python.

fran6co · 2021-05-26T09:55:31Z

I don't think the problem is python 3.9 given that I'm disabling all python stuff. Right now it's failing on windows inside pybind11 checks that technically are not needed given the current configuration but I haven't seen an easy way to turn it off

ssheorey · 2021-05-26T15:06:47Z

@fran6co Please see this issue isl-org/Open3D#3376
Python is still needed for the build process.
It should work if we can specify the full path to the Python executable as a CMake argument..

Ulysses1337 · 2021-08-18T18:59:05Z

I really appreciate your effort to take on this ill-designed behemoth. Presumably I'm not alone in my desire to just process point clouds. I don't want the bloat of an asset importer or renderer, neither do I want to inherit someone else's logger macros. Does it look like it will be feasible to make the major sideshows optional?

fran6co · 2021-08-18T21:46:27Z

I think it should be, my goal was to just create a baseline, get it compiling and integrated to vcpkg with some of the features. Probably the lifecycle it’s going to be: get all the features working first and then making them optional later

…

On Wed, 18 Aug 2021 at 20:59, Ulysses1337 ***@***.***> wrote: I really appreciate your effort to take on this ill-designed behemoth. Presumably I'm not alone in my desire to just process point clouds. I don't want the bloat of an asset importer or renderer, neither do I want to inherit someone else's logger macros. Does it look like it will be feasible to make the major sideshows optional? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17423 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFRISHFESLURJC2CZFV263T5P7ILANCNFSM43KTRAXA> .

JackBoosY · 2021-09-10T07:05:33Z

Any progress here?

fran6co · 2021-09-10T07:29:37Z

Might resume work on it in the next weeks, but no promises

NancyLi1013 · 2021-09-29T07:38:35Z

Need to resolve the conflicts. @fran6co

NancyLi1013 · 2021-11-02T02:28:49Z

Is work still being done for this PR? @fran6co

fran6co · 2021-11-02T07:22:01Z

Is work still being done for this PR? @fran6co

No, I don’t have time to work on it

NancyLi1013 · 2021-11-02T08:43:13Z

Thanks for your contribution and response. @fran6co

We're closing this for now since there's been no progress for a long time. If you'd like to continue working on it, please reopen and ping us!

hectorpiteau · 2024-05-23T22:57:48Z

@fran6co Is there a way to help you on this? I know it's been a while but it would be cool to reopen the issue

QiuYilin · 2024-06-06T02:01:11Z

Is there any progress on this?

fran6co force-pushed the open3d branch 2 times, most recently from 8b6080b to e37a3de Compare April 21, 2021 15:43

fran6co mentioned this pull request Apr 21, 2021

Add vcpkg support isl-org/Open3D#767

Open

fran6co force-pushed the open3d branch 3 times, most recently from 45d855c to 34a73aa Compare April 21, 2021 16:14

NancyLi1013 assigned NancyLi1013 and JackBoosY Apr 22, 2021

NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 22, 2021

NancyLi1013 suggested changes Apr 22, 2021

View reviewed changes

ports/poissonrecon/CONTROL Outdated Show resolved Hide resolved

ports/tinygltf/portfile.cmake Outdated Show resolved Hide resolved

ports/poissonrecon/intel-isl.patch Outdated Show resolved Hide resolved

ports/poissonrecon/CMakeLists.txt Outdated Show resolved Hide resolved

NancyLi1013 added depends:different-pr This PR or Issue depends on a PR which has been filed requires:author-response labels Apr 22, 2021

fran6co force-pushed the open3d branch 3 times, most recently from d98b1cc to d514069 Compare April 22, 2021 11:02

This was referenced Apr 26, 2021

[New Port Request] Open3D #11950

Closed

[New Port Request] Open3D #15980

Closed

fran6co force-pushed the open3d branch from d514069 to 2180d9e Compare May 7, 2021 08:50

NancyLi1013 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label May 7, 2021

fran6co force-pushed the open3d branch 3 times, most recently from 05805b5 to 855151a Compare May 10, 2021 09:19

JackBoosY added the depends:upstream-changes Waiting on a change to the upstream project label May 25, 2021

fran6co force-pushed the open3d branch from 855151a to 91c7c7e Compare May 26, 2021 09:22

fran6co force-pushed the open3d branch from 4fbf066 to 6d05f31 Compare August 1, 2021 08:27