Skip to content

[getdns] Add new port. #12090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 7, 2020
Merged

[getdns] Add new port. #12090

merged 9 commits into from
Jul 7, 2020

Conversation

banburybill
Copy link
Contributor

@banburybill banburybill commented Jun 24, 2020 •
edited
Loading

Add new port for getdns (https://getdnsapi.net).

  • What does your PR fix? Fixes [New Port Request] getdns #12075

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    All CI failures appear to be in other packages. I have verified x64-windows, x86-windows, x64-windows-static and x86-windows-static build.

  • Does your PR follow the maintainer guide?
    I think so. Two of the 3 patches applied are submitted upstream, the other is waiting for a response from the chief maintainer on whether it's a CMakeLists.txt problem or a packaging problem.

@ghost
Copy link

ghost commented Jun 24, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@banburybill banburybill marked this pull request as ready for review June 24, 2020 21:19
@NancyLi1013 NancyLi1013 self-assigned this Jun 28, 2020
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013
NancyLi1013 suggested changes Jun 28, 2020
View reviewed changes
@NancyLi1013 NancyLi1013 added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Jun 28, 2020
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

The failures on x64-uwp and arm-uwp triplets:

4>D:\buildtrees\getdns\src\1.6.0-ba09677cce\src\platform.c(56,17): error C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\getdns\x64-uwp-dbg\getdns_objects.vcxproj]
         ub_loop.c
     4>D:\buildtrees\getdns\src\1.6.0-ba09677cce\src\anchor.c(108,6): error C4996: 'sscanf': This function or variable may be unsafe. Consider using sscanf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\getdns\x64-uwp-dbg\getdns_objects.vcxproj]
     4>D:\buildtrees\getdns\src\1.6.0-ba09677cce\src\anchor.c(122,6): error C4996: 'sscanf': This function or variable may be unsafe. Consider using sscanf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\getdns\x64-uwp-dbg\getdns_objects.vcxproj]
     4>D:\buildtrees\getdns\src\1.6.0-ba09677cce\src\anchor.c(972,3): error C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\getdns\x64-uwp-dbg\getdns_objects.vcxproj]
     4>D:\buildtrees\getdns\src\1.6.0-ba09677cce\src\anchor.c(977,3): error C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\getdns\x64-uwp-dbg\getdns_objects.vcxproj]
     4>D:\buildtrees\getdns\src\1.6.0-ba09677cce\src\convert.c(1649,10): error C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\getdns\x64-uwp-dbg\getdns_objects.vcxproj]

Could you please look into this and try to fix it?

@banburybill
Copy link
Contributor Author

There's at least one Win32 API being used in GetDNS which is not supported in UWP. I don't have time to properly investigate and correct this myself right now, so for the moment I've marked it as not supported under UWP and filed a bug with upstream.

@NancyLi1013
Copy link
Contributor

Have you tested these features? Can these work well?

NancyLi1013
NancyLi1013 reviewed Jul 1, 2020
View reviewed changes
NancyLi1013
NancyLi1013 suggested changes Jul 3, 2020
View reviewed changes
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 6, 2020
ras0219-msft
ras0219-msft reviewed Jul 6, 2020
View reviewed changes
@ras0219-msft ras0219-msft merged commit e1285b4 into microsoft:master Jul 7, 2020
@ras0219-msft
Copy link
Collaborator

LGTM, thanks for the PR!

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Jul 7, 2020
@Jimmy-Hu
Merge pull request #248 from microsoft/master
e7234f0 
[getdns] Add new port. (microsoft#12090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft left review comments

+1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@NancyLi1013 NancyLi1013

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Port Request] getdns
3 participants
@banburybill @NancyLi1013 @ras0219-msft