[Simple-FFT] Add new port #11929
Merged
[Simple-FFT] Add new port #11929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
suggested changes
Jun 15, 2020
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
|
License added, thanks to the author of the library |
NancyLi1013
approved these changes
Jun 17, 2020
vicroms
requested changes
Jun 18, 2020
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
approved these changes
Jun 24, 2020
NancyLi1013
approved these changes
Jun 28, 2020
|
LGTM now. Thanks for this PR @Pospelove |
ras0219-msft
reviewed
Jul 7, 2020
ports/simple-fft/portfile.cmake
Outdated
| ${SOURCE_PATH}/include/simple_fft/fft.hpp | ||
| ${SOURCE_PATH}/include/simple_fft/fft_impl.hpp | ||
| ${SOURCE_PATH}/include/simple_fft/fft_settings.h | ||
| DESTINATION ${CURRENT_PACKAGES_DIR}/include/simple-fft |
There was a problem hiding this comment.
Should this be include/simple_fft instead of include/simple-fft since that's the original source structure?
NancyLi1013
approved these changes
Jul 16, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hellozee
pushed a commit
to hellozee/vcpkg
that referenced
this pull request
Sep 11, 2020
* [Simple-FFT] Add new port * Update ports/simple-fft/CONTROL Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com> * Add copyright handling * Update ports/simple-fft/portfile.cmake Co-authored-by: Victor Romero <romerosanchezv@gmail.com> * Update portfile.cmake Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com> Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11928