[vtk] Added opengl feature. #11399

larshg · 2020-05-16T19:33:00Z

Describe the pull request
Adds opengl feature.

Change description of feature: all.

Which triplets are supported/not supported? Have you updated the CI baseline?
all, no.
Does your PR follow the maintainer guide?
yes.

NancyLi1013

Could you please update this

file(COPY ${SOURCE_PATH}/Copyright.txt DESTINATION ${CURRENT_PACKAGES_DIR}/share/vtk)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/vtk/Copyright.txt ${CURRENT_PACKAGES_DIR}/share/vtk/copyright)

as
file(INSTALL ${SOURCE_PATH}/Copyright.txt DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)?

larshg · 2020-05-18T20:00:30Z

Updated.

NancyLi1013 · 2020-05-19T02:07:44Z

Thanks for your update.
Needs to test the features now. I will update the test results once finished.

NancyLi1013 · 2020-05-20T03:20:46Z

The feature tests are blocked by icu

warning: make-4.3-1 is up to date -- skipping
error: could not open file /var/cache/pacman/pkg/libgdbm-1.18.1-3-x86_64.pkg.tar.zst: Child process exited with status 127
error: could not open file /var/cache/pacman/pkg/gdbm-1.18.1-3-x86_64.pkg.tar.zst: Child process exited with status 127
error: failed to commit transaction (cannot open package file)

So we need to fix this issue #11438.

NancyLi1013 · 2020-06-01T06:35:00Z

@larshg
The problem caused by icu has been resolved.
Could you please merge the latest commit to this PR?

larshg · 2020-06-01T07:03:10Z

Isn't a rebase the preferred way?

NancyLi1013 · 2020-06-01T09:01:14Z

I will update this on my local to test features.
You won't merge it any more.

NancyLi1013 · 2020-06-03T02:52:48Z

Hi @larshg
Sorry for the long delay.
Could you please look into the following problems?

The features build failed on x64-windows triplet:

The feature all is broken due to this:

CMake Error at CMake/vtkDownload.cmake:8 (message):
  Attempted to download Module_MomentInvariants when VTK_FORBID_DOWNLOADS is
  ON
Call Stack (most recent call first):
  CMake/vtkModuleRemote.cmake:142 (vtk_download_attempt_check)
  Remote/MomentInvariants.remote.cmake:5 (vtk_fetch_module)
  Remote/CMakeLists.txt:9 (include)

The feature qt, atlmfc, openvr ,paraview is broken due to this:

CMake Error at ThirdParty/hdf5/CMakeLists.txt:26 (message):
  An external MPI-aware HDF5 requires that VTK be built with MPI support as
  well.

The feature python is broken due to this:

CMake Error at CMake/vtkModule.cmake:4140 (message):
  Could not find the Python3 external dependency.
Call Stack (most recent call first):
  Utilities/Python/CMakeLists.txt:49 (vtk_module_find_package)

The feature mpi is broken due to this:

CMake Error at CMake/vtkModule.cmake:959 (message):
  The VTK::IOParallelNetCDF module requires the disabled module VTK::mpi.
Call Stack (most recent call first):
  CMakeLists.txt:251 (vtk_module_scan)

larshg · 2020-06-03T06:16:22Z

All of those features seems to be unrelated to the opengl features? So those features has stopped working since VTK 9 was first added by @Neumann-A ?
I don't really have the time nor knowledge to look into these errors :(

NancyLi1013 · 2020-06-03T07:22:07Z

@larshg

Thanks for your instant reply.

opengl is also broken due to this

-- Found OpenGL: opengl32  found components: OpenGL 
-- vtkDICOM: Building vtkDICOM as a Remote VTK Module
CMake Error at ThirdParty/hdf5/CMakeLists.txt:26 (message):
  An external MPI-aware HDF5 requires that VTK be built with MPI support as
  well.

I will check this on the master later.

Neumann-A · 2020-06-03T08:36:25Z

-- vtkDICOM: Building vtkDICOM as a Remote VTK Module
CMake Error at ThirdParty/hdf5/CMakeLists.txt:26 (message):
An external MPI-aware HDF5 requires that VTK be built with MPI support as
well.

VTK needs to pass -DVTK_GROUP_ENABLE_MPI=YES which it does:

if("mpi" IN_LIST FEATURES)
    list(APPEND ADDITIONAL_OPTIONS
        -DVTK_GROUP_ENABLE_MPI=YES
    )
endif()

Maybe we need to also pass -DVTK_USE_MPI=ON

Change description of feature: all.

larshg · 2020-06-08T11:34:45Z

I have just rebased on master an rebuild vtk[opengl] but didn't encounter any errors?

JackBoosY · 2020-06-09T07:18:16Z

/azp run

azure-pipelines · 2020-06-09T07:18:25Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2020-06-18T07:54:11Z

@larshg
Feature opengl is broken on x64-windows:

-- vtkDICOM: Building vtkDICOM as a Remote VTK Module
CMake Error at ThirdParty/hdf5/CMakeLists.txt:26 (message):
  An external MPI-aware HDF5 requires that VTK be built with MPI support as
  well.

After add -DVTK_USE_MPI=ON, the error is like this:

CMake Error at F:/11399/vcpkg/scripts/buildsystems/vcpkg.cmake:252 (_add_library):
  Target "IONetCDF" links to target "MPI::MPI_C" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Call Stack (most recent call first):
  CMake/vtkModule.cmake:3328 (add_library)
  IO/NetCDF/CMakeLists.txt:10 (vtk_module_add_module)


CMake Error at F:/11399/vcpkg/scripts/buildsystems/vcpkg.cmake:252 (_add_library):
  Target "IOParallelNetCDF" links to target "MPI::MPI_C" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  CMake/vtkModule.cmake:3328 (add_library)
  IO/ParallelNetCDF/CMakeLists.txt:14 (vtk_module_add_module)


CMake Error at F:/11399/vcpkg/scripts/buildsystems/vcpkg.cmake:252 (_add_library):
  Target "IOMINC" links to target "MPI::MPI_C" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?
Call Stack (most recent call first):
  CMake/vtkModule.cmake:3328 (add_library)
  IO/MINC/CMakeLists.txt:15 (vtk_module_add_module)


CMake Error at F:/11399/vcpkg/scripts/buildsystems/vcpkg.cmake:252 (_add_library):
  Target "exodusII" links to target "MPI::MPI_C" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Call Stack (most recent call first):
  CMake/vtkModule.cmake:3328 (add_library)
  ThirdParty/exodusII/vtkexodusII/CMakeLists.txt:300 (vtk_module_add_module)


CMake Error at F:/11399/vcpkg/scripts/buildsystems/vcpkg.cmake:252 (_add_library):
  Target "IOExodus" links to target "MPI::MPI_C" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Call Stack (most recent call first):
  CMake/vtkModule.cmake:3328 (add_library)
  IO/Exodus/CMakeLists.txt:18 (vtk_module_add_module)

larshg · 2020-06-18T08:26:02Z

Do you install it with other features enabled as well? I'm on x64-windows and I don't encounter those errors?

larshg · 2020-06-18T08:26:56Z

larshg · 2020-06-18T08:28:37Z

Ah, maybe I haven't got an MPI-aware HDF5 installed...

larshg · 2020-06-18T08:43:02Z

This is my hdf5:

So this error is probably also present if you just try to install vtk without opengl feature?

NancyLi1013 · 2020-06-18T09:40:54Z

I just try to install vck[opengl]:x64-windows, and it will fail due to the errors.

larshg · 2020-06-18T09:53:14Z

On a clean machine or do you have multiple features installed from hdf5 (specially the parallel feature which adds MPI).

NancyLi1013 · 2020-06-19T01:55:56Z

I try to build it on a clean machine and there are no any errors on x64-windows.
Have you tested it on other triplets?

larshg · 2020-06-19T09:19:07Z

No, I work only on x64-windows with dynamic libraries.
I thought this is why we have CI's running various systems/configs :-)

NancyLi1013 · 2020-06-19T09:33:13Z

Thanks for your update. I will continue to test other triplets.

NancyLi1013 · 2020-06-22T09:55:28Z

Feature opengl has passed with the following triplets:

x86-windows
x64-windows
x64-windows-static

Note: Other features are not changed.

vicroms · 2020-07-02T20:17:19Z

Thanks for the hard work!

* 'master' of https://github.com/microsoft/vcpkg: (1418 commits) [vcpkg integrate] Clean up vcpkg.target file (microsoft#4608) [vcpkg_from_sourceforge] Add retry mirror function (2/2) (microsoft#12018) [pcre2] Restore the https://ftp.pcre.org/ mirror in addition to the SourceForge mirrors. (microsoft#12233) [xercesc] rename feature from xmlch_wchar to xmlch-wchar (microsoft#12205) [safeint] Update to 3.24 (microsoft#12217) [vcpkg] Remove the tombstones and 'ignore' baseline concepts. (microsoft#12197) [msbuild] Revert the importance to Normal (microsoft#12212) [vtk] Added opengl feature. (microsoft#11399) [span-lite] Update to 0.7.0 (microsoft#12206) [cmocka libarchive libiconv libpq libxml2 plibsys] fix drive-by error in vcpkg-cmake-wrappers (microsoft#12196) [azure-iot-sdk-c] Fix feature name and enable to build (microsoft#12209) [vcpkg] Improve performance of compiler tracking by suppressing aspects of CMake's compiler detection. (microsoft#12203) [vcpkg] Remove all uses of Foo::Foo() noexcept = default; to fix microsoft#9955 (microsoft#12201) [sqlite3] update to 3.32.3 to deal with security issues (microsoft#12185) [infoware] Bump version to 0.5.4 (microsoft#12167) [imgui] Update to 1.77 (microsoft#12155) [vcpkg] Update message in bootstrap.ps1 (microsoft#12145) [vcpkg] Enable NuGet-based binary caching via mono (microsoft#12170) Don't change manifest root when manifest isn't enabled. (microsoft#12191) Fix sourceparagraph:BooleanField (microsoft#12192) ...

NancyLi1013 self-assigned this May 18, 2020

NancyLi1013 changed the title ~~Added opengl feature.~~ [vtk] Added opengl feature. May 18, 2020

NancyLi1013 reviewed May 18, 2020

View reviewed changes

NancyLi1013 added the waiting for response label May 18, 2020

NancyLi1013 approved these changes May 19, 2020

View reviewed changes

NancyLi1013 added Needs Testing and removed waiting for response labels May 19, 2020

NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 22, 2020

NancyLi1013 added the requires:author-response label Jun 3, 2020

larshg added 2 commits June 8, 2020 07:49

Added opengl feature.

320c5c2

Change description of feature: all.

Fix copyright

14de66d

larshg force-pushed the AddVTKOpenglOption branch from 338bfa0 to 14de66d Compare June 8, 2020 11:34

NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 22, 2020

vicroms merged commit 2ad4074 into microsoft:master Jul 2, 2020

NancyLi1013 mentioned this pull request Jul 6, 2020

[vtk] update to 9.0.1 #12149

Merged

larshg deleted the AddVTKOpenglOption branch May 5, 2021 15:02

[vtk] Added opengl feature. #11399

[vtk] Added opengl feature. #11399

Uh oh!

Conversation

larshg commented May 16, 2020

Uh oh!

NancyLi1013 left a comment

Choose a reason for hiding this comment

Uh oh!

larshg commented May 18, 2020

Uh oh!

NancyLi1013 commented May 19, 2020

Uh oh!

NancyLi1013 commented May 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented Jun 1, 2020

Uh oh!

larshg commented Jun 1, 2020

Uh oh!

NancyLi1013 commented Jun 1, 2020

Uh oh!

NancyLi1013 commented Jun 3, 2020

Uh oh!

larshg commented Jun 3, 2020

Uh oh!

NancyLi1013 commented Jun 3, 2020

Uh oh!

Neumann-A commented Jun 3, 2020

Uh oh!

larshg commented Jun 8, 2020

Uh oh!

JackBoosY commented Jun 9, 2020

Uh oh!

azure-pipelines bot commented Jun 9, 2020

Uh oh!

NancyLi1013 commented Jun 18, 2020

Uh oh!

larshg commented Jun 18, 2020

Uh oh!

larshg commented Jun 18, 2020

Uh oh!

larshg commented Jun 18, 2020

Uh oh!

larshg commented Jun 18, 2020

Uh oh!

NancyLi1013 commented Jun 18, 2020

Uh oh!

larshg commented Jun 18, 2020

Uh oh!

NancyLi1013 commented Jun 19, 2020

Uh oh!

larshg commented Jun 19, 2020

Uh oh!

NancyLi1013 commented Jun 19, 2020

Uh oh!

NancyLi1013 commented Jun 22, 2020

Uh oh!

vicroms commented Jul 2, 2020

Uh oh!

Uh oh!

NancyLi1013 commented May 20, 2020 •

edited

Loading