Skip to content

Conversation

alexander-smyslov
Copy link
Contributor

Describe the pull request

  • What does your PR fix?
    new port avro-cpp

  • Which triplets are supported/not supported? x64-windows, x86-windows, x64-linux
    Have you updated the CI baseline?

  • Does your PR follow the maintainer guide?
    yes

@NancyLi1013 NancyLi1013 self-assigned this May 18, 2020
Alexander Smyslov added 2 commits May 18, 2020 10:18
@NancyLi1013
Copy link
Contributor

Could you please resolve the conflicts?

@alexander-smyslov
Copy link
Contributor Author

alexander-smyslov commented May 19, 2020

Could you please resolve the conflicts?
in documentation - avro-cpp can compile under osx and linux
I try to compile under linux without success.
So lets add as windows only port and I will try to add linux support later

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

alexander-smyslov and others added 2 commits June 12, 2020 10:17
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@alexander-smyslov
Copy link
Contributor Author

done

@NancyLi1013
Copy link
Contributor

@alexander-smyslov
Could you please look into the error on x64-windows-static?

Creating library avrocpp.lib and object avrocpp.exp
DataFile.cc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: static void __cdecl boost::iostreams::zlib_error::check(int)" (__imp_?check@zlib_error@iostreams@boost@@SAXH@Z) referenced in function "public: bool __cdecl boost::iostreams::detail::zlib_compressor_impl<class std::allocator<char> >::filter(char const * &,char const *,char * &,char *,bool)" (?filter@?$zlib_compressor_impl@V?$allocator@D@std@@@detail@iostreams@boost@@QEAA_NAEAPEBDPEBDAEAPEADPEAD_N@Z)
DataFile.cc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) protected: __cdecl boost::iostreams::detail::zlib_base::zlib_base(void)" (__imp_??0zlib_base@detail@iostreams@boost@@IEAA@XZ) referenced in function "public: __cdecl boost::iostreams::detail::zlib_compressor_impl<class std::allocator<char> >::zlib_compressor_impl<class std::allocator<char> >(struct boost::iostreams::zlib_params const &)" (??0?$zlib_compressor_impl@V?$allocator@D@std@@@detail@iostreams@boost@@QEAA@AEBUzlib_params@23@@Z)
DataFile.cc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) protected: __cdecl boost::iostreams::detail::zlib_base::~zlib_base(void)" (__imp_??1zlib_base@detail@iostreams@boost@@IEAA@XZ) referenced in function "int `public: __cdecl boost::iostreams::detail::zlib_compressor_impl<class std::allocator<char> >::zlib_compressor_impl<class std::allocator<char> >(struct iostreams::detail::zlib_params const &)'::`1'::dtor$0" (?dtor$0@?0???0?$zlib_compressor_impl@V?$allocator@D@std@@@detail@iostreams@boost@@QEAA@AEBUzlib_params@23@@Z@4HA)
DataFile.cc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) protected: void __cdecl boost::iostreams::detail::zlib_base::before(char const * &,char const *,char * &,char *)" (__imp_?before@zlib_base@detail@iostreams@boost@@IEAAXAEAPEBDPEBDAEAPEADPEAD@Z) referenced in function "public: bool __cdecl boost::iostreams::detail::zlib_compressor_impl<class std::allocator<char> >::filter(char const * &,char const *,char * &,char *,bool)" (?filter@?$zlib_compressor_impl@V?$allocator@D@std@@@detail@iostreams@boost@@QEAA_NAEAPEBDPEBDAEAPEADPEAD_N@Z)
DataFile.cc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) protected: void __cdecl boost::iostreams::detail::zlib_base::after(char const * &,char * &,bool)" (__imp_?after@zlib_base@detail@iostreams@boost@@IEAAXAEAPEBDAEAPEAD_N@Z) referenced in function "public: bool __cdecl boost::iostreams::detail::zlib_compressor_impl<class std::allocator<char> >::filter(char const * &,char const *,char * &,char *,bool)" (?filter@?$zlib_compressor_impl@V?$allocator@D@std@@@detail@iostreams@boost@@QEAA_NAEAPEBDPEBDAEAPEADPEAD_N@Z)
DataFile.cc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) protected: int __cdecl boost::iostreams::detail::zlib_base::xdeflate(int)" (__imp_?xdeflate@zlib_base@detail@iostreams@boost@@IEAAHH@Z) referenced in function "public: bool __cdecl boost::iostreams::detail::zlib_compressor_impl<class std::allocator<char> >::filter(char const * &,char const *,char * &,char *,bool)" (?filter@?$zlib_compressor_impl@V?$allocator@D@std@@@detail@iostreams@boost@@QEAA_NAEAPEBDPEBDAEAPEADPEAD_N@Z)
DataFile.cc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) protected: int __cdecl boost::iostreams::detail::zlib_base::xinflate(int)" (__imp_?xinflate@zlib_base@detail@iostreams@boost@@IEAAHH@Z) referenced in function "public: bool __cdecl boost::iostreams::detail::zlib_decompressor_impl<class std::allocator<char> >::filter(char const * &,char const *,char * &,char *,bool)" (?filter@?$zlib_decompressor_impl@V?$allocator@D@std@@@detail@iostreams@boost@@QEAA_NAEAPEBDPEBDAEAPEADPEAD_N@Z)
DataFile.cc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) protected: void __cdecl boost::iostreams::detail::zlib_base::reset(bool,bool)" (__imp_?reset@zlib_base@detail@iostreams@boost@@IEAAX_N0@Z) referenced in function "public: __cdecl boost::iostreams::detail::zlib_compressor_impl<class std::allocator<char> >::~zlib_compressor_impl<class std::allocator<char> >(void)" (??1?$zlib_compressor_impl@V?$allocator@D@std@@@detail@iostreams@boost@@QEAA@XZ)
DataFile.cc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) private: void __cdecl boost::iostreams::detail::zlib_base::do_init(struct boost::iostreams::zlib_params const &,bool,void * (__cdecl*)(void *,unsigned int,unsigned int),void (__cdecl*)(void *,void *),void *)" (__imp_?do_init@zlib_base@detail@iostreams@boost@@AEAAXAEBUzlib_params@34@_NP6APEAXPEAXII@ZP6AX22@Z2@Z) referenced in function "protected: void __cdecl boost::iostreams::detail::zlib_base::init<class std::allocator<char> >(struct boost::iostreams::zlib_params const &,bool,struct boost::iostreams::detail::zlib_allocator<class std::allocator<char>,class std::allocator<char> > &)" (??$init@V?$allocator@D@std@@@zlib_base@detail@iostreams@boost@@IEAAXAEBUzlib_params@23@_NAEAU?$zlib_allocator@V?$allocator@D@std@@V12@@123@@Z)
DataFile.cc.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) int const boost::iostreams::zlib::default_compression" (__imp_?default_compression@zlib@iostreams@boost@@3HB)
DataFile.cc.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) int const boost::iostreams::zlib::deflated" (__imp_?deflated@zlib@iostreams@boost@@3HB)
DataFile.cc.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) int const boost::iostreams::zlib::default_strategy" (__imp_?default_strategy@zlib@iostreams@boost@@3HB)
DataFile.cc.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) int const boost::iostreams::zlib::stream_end" (__imp_?stream_end@zlib@iostreams@boost@@3HB)
DataFile.cc.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) int const boost::iostreams::zlib::finish" (__imp_?finish@zlib@iostreams@boost@@3HB)
DataFile.cc.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) int const boost::iostreams::zlib::no_flush" (__imp_?no_flush@zlib@iostreams@boost@@3HB)
DataFile.cc.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) int const boost::iostreams::zlib::sync_flush" (__imp_?sync_flush@zlib@iostreams@boost@@3HB)
avrocpp.dll : fatal error LNK1120: 16 unresolved externals
[47/55] "C:\PROGRA~2\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.26.28801\bin\Hostx64\x64\cl.exe"   /TP -DAVRO_SOURCE -DBOOST_ALL_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_IOSTREAMS_DYN_LINK -DBOOST_LIB_DIAGNOSTIC -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_REGEX_DYN_LINK -DBOOST_SYSTEM_DYN_LINK -DNOMINMAX -ID:\buildtrees\avro-cpp\src\ease-1.9.2-f20e8a202e\lang\c++\api -I. -ID:\install\x64-windows-static\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1    /EHa /showIncludes /FoCMakeFiles\avrocpp_s.dir\impl\json\JsonDom.cc.obj /FdCMakeFiles\avrocpp_s.dir\avrocpp_s.pdb /FS -c D:\buildtrees\avro-cpp\src\ease-1.9.2-f20e8a202e\lang\c++\impl\json\JsonDom.cc
cl : Command line warning D9025 : overriding '/EHs' with '/EHa'
[48/55] "C:\PROGRA~2\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.26.28801\bin\Hostx64\x64\cl.exe"   /TP -DAVRO_SOURCE -DBOOST_ALL_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_IOSTREAMS_DYN_LINK -DBOOST_LIB_DIAGNOSTIC -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_REGEX_DYN_LINK -DBOOST_SYSTEM_DYN_LINK -DNOMINMAX -ID:\buildtrees\avro-cpp\src\ease-1.9.2-f20e8a202e\lang\c++\api -I. -ID:\install\x64-windows-static\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1    /EHa /showIncludes /FoCMakeFiles\avrocpp_s.dir\impl\json\JsonIO.cc.obj /FdCMakeFiles\avrocpp_s.dir\avrocpp_s.pdb /FS -c D:\buildtrees\avro-cpp\src\ease-1.9.2-f20e8a202e\lang\c++\impl\json\JsonIO.cc
cl : Command line warning D9025 : overriding '/EHs' with '/EHa'

@NancyLi1013
Copy link
Contributor

@alexander-smyslov
Since it still failed on x64-windows-static. We also need to add avro-cpp:x64-windows-static=fail to ci.baseline.txt.
Sorry, I misunderstand this before.

@alexander-smyslov
Copy link
Contributor Author

@alexander-smyslov
Since it still failed on x64-windows-static. We also need to add avro-cpp:x64-windows-static=fail to ci.baseline.txt.
Sorry, I misunderstand this before.

fixed

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jun 22, 2020
@JackBoosY
Copy link
Contributor

@strega-nil No.. don't merge baseline on github page, it will replace LF to CRLF every row.

@strega-nil
Copy link
Contributor

@JackBoosY doesn't look like it did...

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit 021db93 into microsoft:master Aug 1, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
* Add files via upload

* [new port] avro-cpp

* add boost-format

* remove comments

* remove comments

* avro-cpp 1.9.2

* avro-cpp 1.9.2

* avro-cpp 1.9.2

* avro-cpp 1.9.2

* avro-cpp 1.9.2

* avro-cpp 1.9.2

* fix remarks

* fix remarks

* fix remarks

* Update ports/avro-cpp/portfile.cmake

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

* Update ports/avro-cpp/portfile.cmake

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

* add linux support

* back osx restriction

* Update ports/avro-cpp/portfile.cmake

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

* fix remarks

* Update ports/avro-cpp/CONTROL

* Update ports/avro-cpp/portfile.cmake

* add osx support

* Update portfile.cmake

* Update CONTROL

* Update scripts/ci.baseline.txt

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

* fix

* disable all static build

* fix remarks

* fix remarks

* Update ports/avro-cpp/portfile.cmake

Remove whitespace

Co-authored-by: Alexander Smyslov <aleksandr.smyslov@libertexgroup.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: Smyslov Alexander Nikolayevich <aleksandr.smyslov@fxclub.com>
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
@alexander-smyslov alexander-smyslov deleted the avro-cpp-2 branch April 26, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants