Skip to content

Fix possible deadlock inside MSBuild task #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 22, 2024
Merged

Fix possible deadlock inside MSBuild task #3307

merged 4 commits into from
Jul 22, 2024

Conversation

MarcoRossignoli
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli commented Jul 22, 2024 •
edited
Loading

  • I don't recall why we went for a blocking wait. We have and hang on this line only for 6.0 so it could be a deadlock due to the blocking wait. Token is correctly signaled.
  • Setup the pipe to be async

Fixes #3295

Evangelink
Evangelink previously approved these changes Jul 22, 2024
View reviewed changes
@Evangelink Evangelink enabled auto-merge (squash) July 22, 2024 14:53
@MarcoRossignoli MarcoRossignoli marked this pull request as draft July 22, 2024 15:03
auto-merge was automatically disabled July 22, 2024 15:03

Pull request was converted to draft

@MarcoRossignoli MarcoRossignoli marked this pull request as ready for review July 22, 2024 15:40
@MarcoRossignoli MarcoRossignoli merged commit 7abac08 into microsoft:main Jul 22, 2024
@MarcoRossignoli MarcoRossignoli deleted the dev/mr/fixmsbuild branch July 22, 2024 16:48
Evangelink pushed a commit that referenced this pull request Aug 2, 2024
@MarcoRossignoli @Evangelink
Fix possible deadlock inside MSBuild task (#3307)
76c9e7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running tests targeting net6.0 are stuck
2 participants
@MarcoRossignoli @Evangelink