Skip to content

Update TestContext.Properties return type to IDictionary<string, object?> #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 19, 2022
Merged

Update TestContext.Properties return type to IDictionary<string, object?> #1481

merged 10 commits into from
Dec 19, 2022

Conversation

engyebrahim
Copy link
Member

fix: #1377

@engyebrahim engyebrahim changed the title Update test context.properties return type to IDictionary<string, object> Update test context.properties return type to Dictionary<string, object?> Dec 19, 2022
@Evangelink Evangelink changed the title Update test context.properties return type to Dictionary<string, object?> Update TestContext.Properties return type to Dictionary<string, object?> Dec 19, 2022
Evangelink
Evangelink reviewed Dec 19, 2022
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simplify furthermore the GetProperty method of TestContext.

@MarcoRossignoli Do you think we should go with IDictionary over Dictionary?

@MarcoRossignoli
Copy link
Contributor

@MarcoRossignoli Do you think we should go with IDictionary over Dictionary?

I would use always abstraction if possible so yes.

@engyebrahim engyebrahim changed the title Update TestContext.Properties return type to Dictionary<string, object?> Update TestContext.Properties return type to IDictionary<string, object?> Dec 19, 2022
@Evangelink Evangelink enabled auto-merge (squash) December 19, 2022 15:49
@Evangelink Evangelink merged commit f277097 into microsoft:main Dec 19, 2022
engyebrahim added a commit that referenced this pull request May 17, 2023
@engyebrahim
Revert "Update TestContext.Properties return type to IDictionary<stri…
957a88e 
…ng, object?> (#1481)"

This reverts commit f277097.
engyebrahim added a commit that referenced this pull request May 17, 2023
@engyebrahim
Revert "Revert "Update TestContext.Properties return type to IDiction…
c9d65ce 
…ary<string, object?> (#1481)""

This reverts commit 957a88e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update TestContext.Properties return type to IDictionary<string, object>
3 participants
@engyebrahim @MarcoRossignoli @Evangelink