Fix UnitTestRunner leaking some test class instances #5715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5af132a to
8a8256a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5715 +/- ##
==========================================
- Coverage 76.20% 76.15% -0.06%
==========================================
Files 602 602
Lines 36707 36755 +48
==========================================
+ Hits 27973 27989 +16
- Misses 8734 8766 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
fhnaseer
reviewed
Jun 10, 2025
fhnaseer
approved these changes
Jun 10, 2025
|
/backport to rel/3.9 |
|
Started backporting to rel/3.9: https://github.com/microsoft/testfx/actions/runs/15556763980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5711
TestMethodInfoholds_classInstance. So storing it in a dictionary that lives for the whole test session will leak the stored test class instances.While I think we could avoid storing
_classInstanceinTestMethodInfo, it's still an "overkill" to storeTestMethodInfoin the dictionary as we end up only accessing eitherTestClassInfoorTestAssemblyInfo.So, the dictionary is now split to two dictionaries, one that stores class fixtures and the other stores assembly fixtures. This in theory is still bad because as the number of test classes grow, this dictionary can grow, and also this dictionary is only ever used when
ConsiderFixturesAsSpecialTestsis enabled, but we still always create the dictionary. But this is a step forward as it at least avoids rooting test class instances.