Fix UseAsync property in TestMethodAttribute derived classes to use type checks #5708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where custom
TestMethodAttribute
derived classes were incorrectly falling back to synchronous execution instead of using their async implementations.Problem
The
TestMethodAttribute
constructor setsUseAsync = GetType() == typeof(TestMethodAttribute)
, which evaluates tofalse
for derived classes. However, derived classes likeUITestMethodAttribute
,DataTestMethodAttribute
, andSTATestMethodAttribute
were overriding theUseAsync
property to returntrue
directly:This caused inconsistent behavior where the framework would fall back to the synchronous
Execute
method instead of using the asynchronousExecuteAsync
method that these attributes implement.Solution
Updated all derived
TestMethodAttribute
classes to use the same type-checking pattern as the base class:This ensures that:
TestMethodAttribute
constructor logicFiles Changed
UWP_UITestMethodAttribute.cs
: UseAsync now checks for exactUITestMethodAttribute
typeWinUI_UITestMethodAttribute.cs
: UseAsync now checks for exactUITestMethodAttribute
typeDataTestMethodAttribute.cs
: UseAsync now checks for exactDataTestMethodAttribute
typeSTATestMethodAttribute.cs
: UseAsync now checks for exactSTATestMethodAttribute
typeEach change is minimal and surgical - exactly one line modified per file.
Impact
This fix ensures that custom test method attributes properly use their async execution paths, which is especially important for UI testing scenarios where execution must happen on specific threads.
Fixes #5707.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
4vyvsblobprodcus361.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)8xbvsblobprodcus382.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)bcnvsblobprodcus378.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)i1qvsblobprodcus353.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)l49vsblobprodcus358.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)mfjvsblobprodcus373.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)s4uvsblobprodcus326.vsblob.vsassets.io
dotnet build src/TestFramework/TestFramework/TestFramework.csproj
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.