-
Notifications
You must be signed in to change notification settings - Fork 282
Avoid loading System.Threading.Tasks.Extensions when not needed #5694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
59e05f2
to
2936222
Compare
/backport to rel/3.9 |
Started backporting to rel/3.9: https://github.com/microsoft/testfx/actions/runs/15442261447 |
/backport to rel/3.9 |
Started backporting to rel/3.9: https://github.com/microsoft/testfx/actions/runs/15443366680 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5694 +/- ##
==========================================
- Coverage 76.39% 76.34% -0.05%
==========================================
Files 600 600
Lines 36743 36767 +24
==========================================
+ Hits 28068 28069 +1
- Misses 8675 8698 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Do you need a test for the situation that this is trying to "fix"? If the binding redirects are messed up, it typically leads to end-less stream of problems. This workaround is likely just kicking the can down the road. |
Probably, I can try to create a scenario where this is broken.
I definitely agree. Once the user for example tries to actually use |
I'll get to writing a test for this later as few important stuff are showing up. |
…oussef1313 in #5694 (backport to rel/3.9) (#5695) Co-authored-by: Youssef1313 <youssefvictor00@gmail.com>
This works-around cases where binding redirects are not properly generated in consumer projects, either due to missing Microsoft.NET.Test.Sdk dependency, or due to reasons not yet known.